Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phase1 (2017) tracking sequence #13149

Closed

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Feb 1, 2016

This PR updates the Phase1 tracking sequence from the Phase1PU70 to the one presented in tracking POG meeting Feb 1st. The performance comparison against Phase1PU70 and run2 tracking (in phase1 detector) can be found from
https://indico.cern.ch/event/489234/contribution/5/attachments/1220760/1784567/slides_phase1.pdf
Due to the situation of the phase1 workflows (see the points below), the main purposes of this PR are to allow review/discussion on the implementation, and the use of the sequence e.g. for track selection MVA training.

Since the era migration of the reconstruction part of the phase1 customization is still pending, the new sequence is added following the current pattern (full configuration fragments + customize function). The customize for the Phase1PU70 is kept, and another customize for running run2 tracking in phase1 detector is added for reference. The tracking configuration is selected by changing which line in phase1TkCustoms.py is uncommented (not too handy, but hopefully good-enough while waiting for better solutions, see e.g. https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3597/1/2/1.html and onwards).

Also the effects on phase1 can't be easily tested before #12806 gets merged one way or another, and MultiTrackValidator configuration gets additional tuning for the iterations (that depends on #12806 and hence is not included in here).

Tested in 8_0_0_pre5. No changes expected in run2 workflows, for phase1 -w upgrade -l 10000 runs.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

RecoTracker/Configuration
RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@VinInn
Copy link
Contributor

VinInn commented Feb 1, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10892/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

@slava77
Copy link
Contributor

slava77 commented Feb 3, 2016

@makortel @VinInn @rovere
What are the expectations for this PR with respect to integration in CMSSW, considering the era plans.
It sounds like this setup will be scrapped on a time scale of one pre-release or so.
If that's the case, should this stay in "RFC" (request for comments) state and be closed so that it does not stand in line for the imminent integration in CMSSW?

@@ -427,3 +638,32 @@ def customise_Reco(process,pileup):
process.preDuplicateMergingDisplacedTracks.trackProducers.remove("muonSeededTracksInOut")

return process

def customise_Reco_Run2(process):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run2 spans move to Phase1. So, better not introduce much confusion. Maybe _Run2_Legacy and Run2_Phase1

@makortel
Copy link
Contributor Author

makortel commented Feb 3, 2016

@slava77 I will close this one for now. Additional reasons include

I can wait for the era plan to be finalized (let's hope it won't take too long) before the integration, as that way there is less moving customizations back and forth. @VinInn @rovere what do you think?

Anyway, I won't touch this branch, so it remains possible to run this version of phase1 tracking on 800pre5 (but no later) if anybody wants/needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants