Migrate remaining 2017 reco customizations to era

[makortel]

This PR completes the migration of 2017 reconstruction customizations from phase1TkCustoms to phase1Pixel/trackingPhase1 eras that was started in #13477. The produced configurations before and after this PR are not exactly the same. Functionally they are, with the exception that with this PR the castor reconstruction modules are run (following #13591).

The only non-straightforward part was the treatment of non-splitted siPixelClusters for the Phase1PU70 tracking. The issue was discussed in #13381 and in March 3 RECO meeting https://indico.cern.ch/event/505422/contribution/5/attachments/1237476/1817746/slides_trk_phase1_era.pdf, and the impelemented way is to use both siPixelClustersPreSplitting and siPixelClusters for non-splitted clusters for Phase1PU70.

Next step is to switch the default 2017 tracking to the one in #13149 (Phase1PU70 will be left as a reference that can be switched on with Run2_2017_trackingPhase1PU70 era).

Tested in CMSSW_8_1_X_2016-03-08-2300 (runTheMatrix.py -i all -l limited,25202.0,10024.0,10224.0), no changes expected in monitored quantities.

@rovere @VinInn

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

Configuration/StandardSequences
RecoJets/JetProducers
RecoLocalTracker/SiPixelClusterizer
RecoMuon/Configuration
RecoPixelVertexing/Configuration
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTrackFitting
RecoPixelVertexing/PixelTriplets
RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking
RecoTracker/MeasurementDet
SLHCUpgradeSimulations/Configuration

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @yslai, @abbiendi, @rappoccio, @Martin-Grunewald, @threus, @battibass, @ahinzmann, @jhgoh, @jdolen, @cerati, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @nhanvtran, @schoef, @mschrode, @dgulhan, @dkotlins, @gpetruc, @istaslis, @mariadalfonso, @bachtis this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11797/console

[cmsbuild]

+1
Tested at: ed86e3d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13666/11797/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13666/11797/summary.html

[civanch]

+1

[makortel]

It seems that we still don't have any 2017 workflows in the PR tests, right?

[slava77]

The old 2017 workflow number set is still requested in jenkins.
I have missed that #13516 removed the older 2017 workflows to replace them with new ones.
I will need to make updates to get them picked up.
I will do.

[makortel]

Thanks @slava77.

[slava77]

+1

for #13666 ed86e3d

• changes are in line with the description
• jenkins tests pass and comparisons with baseline show no difference
  • the 2017 workflows fell off the jenkins list due to changes in the workflow numbers: cms-bot will pick up the new ones once update 2017 workflows in the matrix cms-bot#648 is merged
• tested locally in CMSSW_8_1_0_pre1 with 10021.0,10024.0,10025.0,10026.0,10023.0,10224.0,10225.0 workfows
  • castor reco objects now appear in the outputs as expected
  • reorganisation of siPixelClusters to use siPixelClustersPreSplitting and PixelLayerTriplets to be PixelLayerTripletsPreSplitting is visible runtime
  • monitored quantities are unchanged