Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hlt hcal movemodulestol1t #13596

Merged
merged 21 commits into from
Mar 15, 2016
Merged

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Mar 4, 2016

Adapting two HCAL modules to use l1t instead of l1extra.

Created two new modules
IsolatedPixelTrackCandidateProducer -> IsolatedPixelTrackCandidateL1TProducer
HLTPixelIsolTrackFilter -> HLTPixelIsolTrackL1TFilter
which replace l1extra jet objects used for taus with l1t tau objects.

This also required the addition of a new constructor to
DataFormats/HcalIsolatedTrack/interface/IsolatedPixelTrackCandidate.h
which uses l1t taus.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_8_0_X.

It involves the following packages:

Calibration/HcalIsolatedTrackReco
DQM/L1TMonitor
DataFormats/HcalIsolatedTrack
EventFilter/L1TRawToDigi
HLTrigger/Configuration
HLTrigger/Egamma
HLTrigger/HLTfilters
HLTrigger/special
L1Trigger/Configuration
L1Trigger/HardwareValidation
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
L1Trigger/L1TNtuples
RecoEgamma/EgammaHLTProducers

The following packages do not have a category, yet:

L1Trigger/L1TMuon

@perrotta, @cmsbuild, @diguida, @cvuosalo, @fwyzard, @cerminar, @Martin-Grunewald, @franzoni, @deguio, @slava77, @mmusich, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @tocheng, @lgray, @Martin-Grunewald, @jalimena, @geoff-smith this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

-1
please rebase to get rid of the other stuff

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

Pull request #13596 was updated. @perrotta, @cmsbuild, @diguida, @cvuosalo, @fwyzard, @cerminar, @Martin-Grunewald, @franzoni, @slava77, @mmusich, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11717/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2016

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2016

@slava77
Copy link
Contributor

slava77 commented Mar 7, 2016

+1

for #13596 98358ef

  • code changes in the reco packages are to add construction of IsolatedPixelTrackCandidate.h with L1T tau
  • jenkins tests pass and comparisons with baseline show no differences

@ssekmen please update the PR description (the first block of text starting with "Moving two HCAL modules") to appropriately describe changes in DataFormats/HcalIsolatedTrack

@Martin-Grunewald
Copy link
Contributor

@diguida, @cerminar @franzoni, @deguio
can you please sign this PR for AlCa?
Thanks!

@ssekmen
Copy link
Contributor Author

ssekmen commented Mar 8, 2016

@slava77 , thanks, I updated the PR description.

@mmusich
Copy link
Contributor

mmusich commented Mar 8, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 15, 2016
@cmsbuild cmsbuild merged commit dd23b6c into cms-sw:CMSSW_8_0_X Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants