-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hlt hcal movemodulestol1t #13596
Hlt hcal movemodulestol1t #13596
Conversation
A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_8_0_X. It involves the following packages: Calibration/HcalIsolatedTrackReco The following packages do not have a category, yet: L1Trigger/L1TMuon @perrotta, @cmsbuild, @diguida, @cvuosalo, @fwyzard, @cerminar, @Martin-Grunewald, @franzoni, @deguio, @slava77, @mmusich, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
-1 |
a768470
to
34a4036
Compare
please test |
The tests are being triggered in jenkins. |
+1 |
+1
@ssekmen please update the PR description (the first block of text starting with "Moving two HCAL modules") to appropriately describe changes in DataFormats/HcalIsolatedTrack |
@slava77 , thanks, I updated the PR description. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Adapting two HCAL modules to use l1t instead of l1extra.
Created two new modules
IsolatedPixelTrackCandidateProducer -> IsolatedPixelTrackCandidateL1TProducer
HLTPixelIsolTrackFilter -> HLTPixelIsolTrackL1TFilter
which replace l1extra jet objects used for taus with l1t tau objects.
This also required the addition of a new constructor to
DataFormats/HcalIsolatedTrack/interface/IsolatedPixelTrackCandidate.h
which uses l1t taus.