L1TRawToDigi Fixes #13607

Martin-Grunewald · 2016-03-06T07:51:49Z

L1TRawToDigi Fixes
Includes a fixed version of @mulhearn 's #13549
and thus replaces that PR; and a fix by @blwiner on the number of algos being unpacked.

cmsbuild · 2016-03-06T07:52:08Z

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_0_X.

It involves the following packages:

EventFilter/L1TRawToDigi

@cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

Martin-Grunewald · 2016-03-06T08:18:45Z

please test

cmsbuild · 2016-03-06T08:19:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11726/console

cmsbuild · 2016-03-06T09:14:27Z

-1
Tested at: bccbe82
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 64 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-03-04-2300/src/EventFilter/L1TRawToDigi/src/implementations_stage2/GlobalExtBlkPacker.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-03-04-2300/src/EventFilter/L1TRawToDigi/src/implementations_stage2/GlobalExtBlkUnpacker.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-03-04-2300/src/EventFilter/L1TRawToDigi/src/implementations_stage2/JetPacker.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-03-04-2300/src/EventFilter/L1TRawToDigi/src/implementations_stage2/JetUnpacker.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-03-04-2300/src/EventFilter/L1TRawToDigi/src/implementations_stage2/L1TObjectCollections.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-03-04-2300/src/DataFormats/L1TGlobal/src/GlobalAlgBlk.cc:27:27: error: unused variable 'maxPhysicsTriggers' [-Werror,-Wunused-const-variable]
const static unsigned int maxPhysicsTriggers = 512;  //TO DO Move this to a standard parameter area.
                          ^
1 error generated.
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-03-04-2300/src/EventFilter/L1TRawToDigi/src/implementations_stage2/L1TStage2Layer2Constants.cc 
Selected class -> edm::Wrapper > for ROOT: edm::Wrapper >

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13607/11726/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4c8d048
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13607/11726/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13607/11726/git-merge-result

cmsbuild · 2016-03-06T09:24:26Z

Pull request #13607 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again.

Martin-Grunewald · 2016-03-06T09:24:30Z

please test

cmsbuild · 2016-03-06T09:24:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11728/console

cmsbuild · 2016-03-06T10:06:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13607/11726/summary.html

cmsbuild · 2016-03-06T15:21:15Z

+1
Tested at: bdcdd39
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13607/11729/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4c8d048
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13607/11729/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13607/11729/git-merge-result

cmsbuild · 2016-03-06T16:24:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13607/11729/summary.html

mulhearn · 2016-03-07T10:11:27Z

+1

cmsbuild · 2016-03-07T10:11:46Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

fwyzard · 2016-03-07T11:12:25Z

EventFilter/L1TRawToDigi/src/implementations_stage2/GlobalAlgBlkUnpacker.cc

-	     int algBit = bt+wd*32+algOffset;
-             if(val==1 && algBit < 128) { //FIX ME...get dimension from object
+	     unsigned int algBit = bt+wd*32+algOffset;
+             if(val==1 && algBit < alg.maxPhysicsTriggers) { //FIX ME...get dimension from object


will this affect the behaviour of the HLTL1TSeed modules when we run over data with CMSSW_8_0_1 ?

mulhearn · 2016-03-07T11:41:50Z

Yes, in 801 (until it is patched) the HLTL1TSeed filter will be rejecting events in paths that require triggers above bit 128...

-Mike

davidlange6 · 2016-03-08T10:45:12Z

+1

L1TRawToDigi Fixes

davidlange6 · 2016-03-08T12:46:34Z

@Martin-Grunewald @mulhearn - I just notice the data format changes - are they really required? makes a patch impossible

Martin-Grunewald · 2016-03-08T12:50:08Z

What do you mean? Data member variables are unchanged!

davidlange6 · 2016-03-08T12:58:08Z

its changing headers in data formats

On Mar 8, 2016, at 1:50 PM, Martin Grunewald [email protected] wrote:

What do you mean? Data member variables are unchanged!

—
Reply to this email directly or view it on GitHub.

fwyzard · 2016-03-08T12:58:15Z

I'm afraid this one

const static unsigned int maxPhysicsTriggers = 512;

is needed.

davidlt · 2016-03-08T13:00:41Z

You have to options:

Downgrade this to warning by setting CXXFLAGS in BuildFile.xml
Force compiler to emit it even if it's not used by adding the attribute

davidlt · 2016-03-08T13:03:39Z

Ah, I see maxPhysicsTriggers was moved to a different header. Compilation issues are gone.

Cummulative 80X PRs for 81X: (#13558 #13572 #13588 #13596 #13602 #13607 #13621)

mulhearn and others added 4 commits March 2, 2016 02:12

Change empty payloads from Error to Warning, and stop after 5

66eb1d1

Merged refs/pull/13549/head from repository cms-sw

4c8d048

fix max algo comparison

6adb4aa

L1TRawToDigi unpacker fixes

a8f454b

cmsbuild added this to the Next CMSSW_8_0_X milestone Mar 6, 2016

cmsbuild added l1-pending pending-signatures tests-pending orp-pending comparison-pending labels Mar 6, 2016

Martin-Grunewald mentioned this pull request Mar 6, 2016

HLT/L1T Interface Update cms-l1t-offline/cmssw#103

Open

Magic number 512

bccbe82

cmsbuild added tests-started and removed tests-pending labels Mar 6, 2016

cmsbuild added tests-rejected and removed tests-started labels Mar 6, 2016

Fix

97d27d1

cmsbuild added tests-pending and removed tests-rejected labels Mar 6, 2016

cmsbuild added tests-started and removed tests-pending labels Mar 6, 2016

cmsbuild removed the comparison-pending label Mar 6, 2016

cmsbuild added comparison-available and removed comparison-pending labels Mar 6, 2016

cmsbuild added comparison-pending and removed comparison-available labels Mar 6, 2016

cmsbuild added comparison-available and removed comparison-pending labels Mar 6, 2016

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Mar 7, 2016

fwyzard reviewed Mar 7, 2016
View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Mar 8, 2016

cmsbuild added a commit that referenced this pull request Mar 8, 2016

Merge pull request #13607 from Martin-Grunewald/L1TRawToDigiFixes

517e222

L1TRawToDigi Fixes

cmsbuild merged commit 517e222 into cms-sw:CMSSW_8_0_X Mar 8, 2016

Martin-Grunewald mentioned this pull request Mar 8, 2016

Cummulative 80X PRs for 81X: (#13558 #13572 #13588 #13596 #13602 #13607 #13621) #13645

Merged

davidlange6 added a commit that referenced this pull request Mar 10, 2016

Merge pull request #13645 from cms-tsg-storm/Cummulative81X

795a33c

Cummulative 80X PRs for 81X: (#13558 #13572 #13588 #13596 #13602 #13607 #13621)

Martin-Grunewald deleted the L1TRawToDigiFixes branch March 22, 2016 07:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

L1TRawToDigi Fixes #13607

L1TRawToDigi Fixes #13607

Martin-Grunewald commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

Martin-Grunewald commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

Martin-Grunewald commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

mulhearn commented Mar 7, 2016

cmsbuild commented Mar 7, 2016

fwyzard Mar 7, 2016

mulhearn commented Mar 7, 2016

davidlange6 commented Mar 8, 2016

davidlange6 commented Mar 8, 2016

Martin-Grunewald commented Mar 8, 2016

davidlange6 commented Mar 8, 2016

fwyzard commented Mar 8, 2016

davidlt commented Mar 8, 2016

davidlt commented Mar 8, 2016

L1TRawToDigi Fixes #13607

L1TRawToDigi Fixes #13607

Conversation

Martin-Grunewald commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

Martin-Grunewald commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

Martin-Grunewald commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

cmsbuild commented Mar 6, 2016

mulhearn commented Mar 7, 2016

cmsbuild commented Mar 7, 2016

fwyzard Mar 7, 2016

Choose a reason for hiding this comment

mulhearn commented Mar 7, 2016

davidlange6 commented Mar 8, 2016

davidlange6 commented Mar 8, 2016

Martin-Grunewald commented Mar 8, 2016

davidlange6 commented Mar 8, 2016

fwyzard commented Mar 8, 2016

davidlt commented Mar 8, 2016

davidlt commented Mar 8, 2016