Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra parameter from HLTL1TSeed module #13621

Merged
merged 2 commits into from
Mar 15, 2016
Merged

Remove extra parameter from HLTL1TSeed module #13621

merged 2 commits into from
Mar 15, 2016

Conversation

Martin-Grunewald
Copy link
Contributor

Remove extra parameter from HLTL1TSeed module

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Mar 7, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/HLTfilters

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11743/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

Pull request #13621 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

+1
Tested at: 7510715
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13621/11743/summary.html

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11746/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

+1
Tested at: 9085d80
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13621/11746/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13621/11743/summary.html

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13621/11746/summary.html

@Martin-Grunewald Martin-Grunewald mentioned this pull request Mar 8, 2016
Merged
davidlange6 added a commit that referenced this pull request Mar 10, 2016
@davidlange6
Merge pull request #13645 from cms-tsg-storm/Cummulative81X
795a33c 
Cummulative 80X PRs for 81X: (#13558 #13572 #13588 #13596 #13602 #13607 #13621)
@Martin-Grunewald Martin-Grunewald mentioned this pull request Mar 14, 2016
Closed
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 15, 2016
@cmsbuild
Merge pull request #13621 from Martin-Grunewald/FixHLTL1TSeedSaveTags
11eeb57 
Remove extra parameter from HLTL1TSeed module
@cmsbuild cmsbuild merged commit 11eeb57 into cms-sw:CMSSW_8_0_X Mar 15, 2016
@Martin-Grunewald Martin-Grunewald deleted the FixHLTL1TSeedSaveTags branch March 22, 2016 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.
3 participants
@Martin-Grunewald @cmsbuild @davidlange6