-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.4.X] add ExhumeGeneratorFilter
to ConcurrentLumisDisable
#39949
[12.4.X] add ExhumeGeneratorFilter
to ConcurrentLumisDisable
#39949
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild, please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
backport of #39143 |
please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75cf73/28720/summary.html Comparison SummarySummary:
|
@cms-sw/generators-l2 please review |
@cms-sw/orp-l2 this is a verbatim backport of #39143 that allows to avoid having crashes in production. Please consider skipping generators signature, since that takes always unusually long. |
+1 Apologize for that |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Follow the suggest in #39041 (comment),
ExhumeGeneratorFilter
is added to theConcurrentLumisDisable
PR validation:
Compare Generator config file from workflow 11725 with 8 threads,
Without PR:
process.options.eventSetup.numberOfConcurrentIOVs = 1
With PR:
process.options.numberOfConcurrentLuminosityBlocks = 1
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #39143