Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] add ExhumeGeneratorFilter to ConcurrentLumisDisable #39949

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 1, 2022

PR description:

Follow the suggest in #39041 (comment), ExhumeGeneratorFilter is added to the ConcurrentLumisDisable

PR validation:

Compare Generator config file from workflow 11725 with 8 threads,
Without PR:
process.options.eventSetup.numberOfConcurrentIOVs = 1
With PR:
process.options.numberOfConcurrentLuminosityBlocks = 1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39143

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Generator (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 1, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75cf73/28706/summary.html
COMMIT: 14873ed
CMSSW: CMSSW_12_4_X_2022-11-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39949/28706/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3719758
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3719722
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Nov 1, 2022

backport of #39143

@mmusich
Copy link
Contributor Author

mmusich commented Nov 1, 2022

please test

  • Let's try again

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75cf73/28720/summary.html
COMMIT: 14873ed
CMSSW: CMSSW_12_4_X_2022-11-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39949/28720/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3719758
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3719722
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2022

@cms-sw/generators-l2 please review

@mmusich
Copy link
Contributor Author

mmusich commented Nov 7, 2022

@cms-sw/orp-l2 this is a verbatim backport of #39143 that allows to avoid having crashes in production. Please consider skipping generators signature, since that takes always unusually long.

@SiewYan
Copy link
Contributor

SiewYan commented Nov 8, 2022

+1

Apologize for that

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 8, 2022

+1

@cmsbuild cmsbuild merged commit e2cfea5 into cms-sw:CMSSW_12_4_X Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants