Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lobby] Attempting to check where you would end up in queue causes you to immediately get booted into observing if there are no xenos to pick. #7988

Closed
3 tasks done
private-tristan opened this issue Jan 3, 2025 · 1 comment · Fixed by #8065
Closed
3 tasks done

[Lobby] Attempting to check where you would end up in queue causes you to immediately get booted into observing if there are no xenos to pick. #7988

private-tristan opened this issue Jan 3, 2025 · 1 comment · Fixed by #8065
Labels
Bug Admin events aren't bugs

Comments

@private-tristan
Copy link
Contributor

Testmerges

#7909: 'Fixes maintainer access to the profiler and clears profiler access whenever admins are loaded.' by Watermelon914 at commit f10699e #6951: 'New "in_hands" and "onmob" icon sprites for objects, small changes and fixes' by LC4492 at commit 1af9bcf #7862: 'Proc Redefinition Linting' by Drulikar at commit f11c329 #7850: 'Acid Runner: Acid gen cap' by TheManWithNoHands at commit b8d2438 #7774: 'req console tgui' by harryob at commit a8c69c9 #7955: 'TGUI Crew Manifest' by nauticall at commit 83fabc7

Round ID

25723

Description of the bug

image

All three of the above happen at the same time when the game asks if you want to be a xeno

PVP.CM.Bug.Report.Lobby.mp4

What's the difference with what should have happened?

The game should tell you what your position in larva queue WOULD be before you get forced into observer mode

How do we reproduce this bug?

  1. attempt to join as xeno so that you can see your larva queue before deciding whether you want to risk spending an hour in deadchat
  2. be immediately sent into the game as a ghost

...

Issue Bingo
@private-tristan private-tristan added the Bug Admin events aren't bugs label Jan 3, 2025
@chefoxara
Copy link

can confirm this happens

@hry-gh hry-gh mentioned this issue Jan 9, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 12, 2025
@hry-gh
restore old confirmation message when joining as xeno (#8065)
9d9c309 
~~this isn't displayed in the lobby screen ui - and it would be an
absolute pain to do so, all the checks done in attempt_to_join_as_xeno
are quite stateful~~ did it anyway

:cl:
fix: you can't accidentally end up ghosting when trying to join as xeno
when no larva are available
/:cl:

closes #7988
closes #7994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

restore old confirmation message when joining as xeno hry-gh/cmss13
2 participants
@private-tristan @chefoxara