Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join as xeno no longer warns you that there arent any xenos available. #7994

Closed
3 tasks done
ClairionCM opened this issue Jan 3, 2025 · 1 comment · Fixed by #8065
Closed
3 tasks done

Join as xeno no longer warns you that there arent any xenos available. #7994

ClairionCM opened this issue Jan 3, 2025 · 1 comment · Fixed by #8065
Labels
Bug Admin events aren't bugs

Comments

@ClairionCM
Copy link
Contributor

Testmerges

#7909: 'Fixes maintainer access to the profiler and clears profiler access whenever admins are loaded.' by Watermelon914 at commit f10699e #6951: 'New "in_hands" and "onmob" icon sprites for objects, small changes and fixes' by LC4492 at commit 1af9bcf #7862: 'Proc Redefinition Linting' by Drulikar at commit f11c329 #7850: 'Acid Runner: Acid gen cap' by TheManWithNoHands at commit b8d2438 #7774: 'req console tgui' by harryob at commit a8c69c9 #7955: 'TGUI Crew Manifest' by nauticall at commit 83fabc7

Round ID

25731

Description of the bug

The warning that you get when joining as xeno doesnt work anymore. Please consult the video:

2025-01-03.19-39-53.mp4

What's the difference with what should have happened?

There used to be a little warning that displayed that there arent any available xenos and what position you would be in the queue if you did observe to try and join as xeno.

How do we reproduce this bug?

  1. Join as xeno when there arent any available
  2. ????
  3. Profit!

Issue Bingo

@ClairionCM ClairionCM added the Bug Admin events aren't bugs label Jan 3, 2025
@benrobey
Copy link

benrobey commented Jan 4, 2025

I noticed this as well, I seem to remember it actually told you what position you would be in the larva queue before joining as xeno and now it doesn't.

github-merge-queue bot pushed a commit that referenced this issue Jan 12, 2025
~~this isn't displayed in the lobby screen ui - and it would be an
absolute pain to do so, all the checks done in attempt_to_join_as_xeno
are quite stateful~~ did it anyway

:cl:
fix: you can't accidentally end up ghosting when trying to join as xeno
when no larva are available
/:cl:

closes #7988
closes #7994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants