Proc Redefinition Linting #7862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
Testmerge Candidate
cmss13-ci
bot
added
Balance
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # code/game/machinery/colony_floodlights.dm # code/game/machinery/vending/cm_vending.dm
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
cm13-github
added a commit
that referenced
this pull request
Dec 31, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 31, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 31, 2024
This was referenced Dec 31, 2024
Closed
Open
cm13-github
added a commit
that referenced
this pull request
Dec 31, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 31, 2024
3 tasks
This was referenced Dec 31, 2024
realforest2001
pushed a commit
to realforest2001/forest-cm13
that referenced
this pull request
Jan 1, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 2, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 2, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 2, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 2, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 2, 2025
harryob
approved these changes
Jan 2, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 2, 2025
This was referenced Jan 2, 2025
Closed
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
This was referenced Jan 4, 2025
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR turns on redefinition warnings (which should fail lints since we Werror). This PR needs testing though as there are going to be actual changes from this refactor. One aspect for example I'm not sure about is whether an area power_change should just always update_icon (vendor code mistakenly was causing this). I have opted to just include that in the proc now and removed redundant calls. Another couple notable example are that
repair_robotic_organsnow has an implementation forrepeat_step_criteriaandpkd_specialrevolvers that aren't al_seriessubtype will no longer have burst changes.TGS DMAPI also fails this, but I am waiting advice on what to do about this, so for now it will serve just as a test to ensure lints fail. See tgstation/tgstation-server#2056 (This is now fixed)
Explain why it's good for the game
In almost all cases, a redefinition is not necessary. And in the few cases it is,
CAN_BE_REDEFINED(TRUE)can be used for the proc. See code changes for examples of all the obvious mistakes allowing redefinitions has caused.Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Drathek
balance: The PKD special burst values have changed for non-"Double" (l_series) variants
code: Code no longer uses proc redefinitions with a few exceptions for global macros
fix: Fixed various things like all backpacks (instead of just JIMA flags) processing
/:cl: