Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace underway status by pending and fix claim test issues #186

Closed
wants to merge 1 commit into from
Closed

Replace underway status by pending and fix claim test issues #186

wants to merge 1 commit into from

Conversation

glours
Copy link
Contributor

@glours glours commented Feb 26, 2020

Fix the following issue in claim test

--- FAIL: TestClaimSchema (2.09s)
    claim_test.go:172: claim validation against the JSON schema failed:
    claim_test.go:174: /result/status: "underway" should be one of ["failure", "success", "pending", "unknown"]

Signed-off-by: Guillaume Lours [email protected]

@glours glours mentioned this pull request Feb 26, 2020
Merged
silvin-lubecki
silvin-lubecki approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
Copy link
Contributor

Related to specifications change: cnabio/cnab-spec#334

@glours glours closed this Feb 26, 2020
@glours
Copy link
Contributor Author

glours commented Feb 26, 2020

Closed already fixed by #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glours @silvin-lubecki