Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_carstate.py needs quick update for OP .4 #172

Closed
Reyuuk opened this issue Jan 10, 2018 · 0 comments
Closed

test_carstate.py needs quick update for OP .4 #172

Reyuuk opened this issue Jan 10, 2018 · 0 comments

Comments

@Reyuuk
Copy link

Reyuuk commented Jan 10, 2018

The current version of OP is incompatible with test_carstate.py. This script is still referencing CS.errors, which has been renamed to CS.events in the rest of OP.

See lines 36 & 26 in https://github.com/commaai/openpilot/blob/devel/selfdrive/debug/test_carstate.py

Also, as an aside, I personally think that this code should also include PATH lines to make it easier to run tests without having to mess with python paths. Adding the below would allow us to run the test with a simple: "python test_carstate.py" - if there's a good reason not to add these imports, feel free to ignore.

import sys
sys.path.append('/data/openpilot')

@pd0wm pd0wm closed this as completed Jun 2, 2019
cfranyota pushed a commit to cfranyota/openpilot-retired that referenced this issue Jun 29, 2019
* Disable Parameter Learning if kegman.json LiveParams = 0

* Do not write ControlsParams or LiveParameters file
pd0wm pushed a commit that referenced this issue Aug 13, 2019
18321a2 toyota DSU cruise message
fa22ebf better VIN msg name
3bf82da VIN signal for toyota
5b466db Forgot to run generator
0132110 Reverse engineer AEB in Honda
ca71b77 rename
c9cf65d toyota pre collision
3835d30 reference toyota DBC
255c16b Lexus CT200 needed one more run of generator
d6c8eca Add Lexus CT200h 2018 (#176)
5d46c29 toyota pre-collision signals
65ace37 fix typo
18968ce pre-collision signals
9b8ae16 add another toyota cancel request signal
a956dee Correct Message ID on LKAS11 (#172)
bce0ec6 typo
a452ac3 Toyota: added 0x283 message description for PRE_COLLISION msg. Data from https://ioactive.com/pdfs/IOActive_Adventures_in_Automotive_Networks_and_Control_Units.pdf

git-subtree-dir: opendbc
git-subtree-split: 18321a2
jyoung8607 pushed a commit to jyoung8607/openpilot that referenced this issue Aug 13, 2019
18321a2 toyota DSU cruise message
fa22ebf better VIN msg name
3bf82da VIN signal for toyota
5b466db Forgot to run generator
0132110 Reverse engineer AEB in Honda
ca71b77 rename
c9cf65d toyota pre collision
3835d30 reference toyota DBC
255c16b Lexus CT200 needed one more run of generator
d6c8eca Add Lexus CT200h 2018 (commaai#176)
5d46c29 toyota pre-collision signals
65ace37 fix typo
18968ce pre-collision signals
9b8ae16 add another toyota cancel request signal
a956dee Correct Message ID on LKAS11 (commaai#172)
bce0ec6 typo
a452ac3 Toyota: added 0x283 message description for PRE_COLLISION msg. Data from https://ioactive.com/pdfs/IOActive_Adventures_in_Automotive_Networks_and_Control_Units.pdf

git-subtree-dir: opendbc
git-subtree-split: 18321a2
sshane referenced this issue in sshane/openpilot Nov 26, 2019
Dynamic follow tuning. Reduced all distances by 10% and quickened dec…
xx979xx referenced this issue in xx979xx/openpilot Dec 9, 2019
DrFritzi pushed a commit to DrFritzi/openpilotOld that referenced this issue Jan 30, 2021
mlocoteta pushed a commit to mlocoteta/openpilot that referenced this issue Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants