feat(adapters): Import the adapters for cornerstone 3D to DICOM SR for annotations #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experiment for a json-schema-based react component that could populate the report.
Introducing babel and Webpack
Needs lowercase dcmjs not DCMJS
* WIP: add skeleton of vtk-js example Currently downloads and displays PET image with vtk-js volume rendering. TODO * segmentation is downloaded but not displayed * layer controls still holdover from cornerstone example * segment lookup table to be defined * multivolume rendering of PET + SEG to be defined * download and interpretation code should move to DICOMZero * enh(packing) add unpack and refactor bit array Now the BitArray class provides static methods to pack and unpack bit and bytes to support dicom SEG encoding. * feat(packing) update create segmentation for new BitArray * enh(dc0) make method static for general use Avoid some duplciation of code by allowing other uses of converting array buffers to datasets. * WIP: improve vtkjs dicom seg example Now loads and displays volumes (e.g. PET) and SEGs as vtkImageData in volume rendering context. TODO: * vtkjs appears not to support left-handed direction matrices, at least in volume rendering (to be further researched) * rendering of the segmentations requires improved lookup tables and smoothing options (e.g. in shader). * XMLHttpRequest code should be migrated either to a helper file in examples or, better, into dicoomweb-client to handle general downloads (e.g. S3, dropbox, static web server, etc). * Adds heuristic when windowing information missing For datasets that have no WindowWidth, WindowCenter use the dataset min/max to make something workable. * Use dicom zero static function correctly * Clean up dicom seg vtkjs example * Ensure dicom values are valid numbers
…r Imaging Measurement Structured Report input / output (#17)
Fixed and refactored BitArray.
chore: first attempt at adding automated build and tagged release on merge to master
Fix: Simpler version number and a new NPM_TOKEN
Fix: turn our new variable string into a var properly
Fix: echo and assign
chore: tidy up formatting and add installation instructions
Add/Remove segments
* Port over image interactor style for volume-based slice viewing * Move camera position rather than distance and clip range * Add 2D slice interactor * New implementation that moves camera pos and fp in sync This makes it easier to handle slicing when the camera view is panned * Add zoom interaction * Physical space slicing * Allow toggle between slice and rotate modes
…ectional measurements
* Refactor * Fix fragment set * default is false * Added legacy methods Fixes #282
* added support for specific character set refactored VR classes refactored reading/writing ascii and encoded strings changed hex writing to direct uint8 writing reimplemented null padded read removed unused code unified test data loading and cache the test data locally for faster test runs * re-enabled test and removed wrong only * fixed test case that was overlooked Co-authored-by: flink <[email protected]>
* moved "eslint-config-prettier" * update lock file Co-authored-by: flink <[email protected]>
- Fix several character sets not working, e.g. "ISO_IR 13" and "ISO_IR 166" - Fix warning being shown when the "ISO_IR 6" character set is used - Add tests for reading encoded string data in several different character sets - Throw exception on an unsupported character set or multiple character sets rather than logging and continuing on (this can be overridden by setting ignoreErrors)
…ters. Safe programming fix only (#301)
…ar to zero (#304) * fix: 🐛 relax condition in nearlyEquals check for detecting numbers near to zero * Update documentation on floating point comparison Co-authored-by: Steve Pieper <[email protected]>
…303) * feat(anonymizer) - export Array tagNamesToEmpty and add parameter in function cleanTags -> manage the tags to anonymize/modify in dicom * fix comma * return a copy of the list tagsNameToEmpty and then pass in the lists as optional arguments to cleanTags Co-authored-by: CASTELNEAU Julien <[email protected]>
…d. Add 3 test (#308) Co-authored-by: CASTELNEAU Julien <[email protected]>
This feature is really just to work around the failed npm publication issue. https://github.com/dcmjs-org/dcmjs/actions/runs/3053711230/jobs/4924682458
Obviously I missed this : )
…sfer syntax (#312) * feat(deflated): Added support for reading datasets with deflated transfer syntax * Updated deflated tests
… is a multi-frame file or not (#320)
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)
✅ Deploy Preview for cornerstone-3d-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to bring cornerstone and cornerstone3d adapters to our monorepo.
dcmjs will have a breaking change in future which removes external adapters and dcmjs will focus specifically on dicom support for maintenance efficiency.
This work is done by @wayfarer3130, Kudos to him.
Command used
npx lerna import --preserve-commit --flatten ../path-to-dcmjs