Add liquidity module to gaia #859

dongsam · 2021-05-20T17:15:25Z

Closes: #858

Description

Add a tendermint/liquidity module to the Gaia for Gravity DEX.

Finalized Liquidity module v1 for Gravity-DEX
- https://github.com/tendermint/liquidity/releases/tag/v1.2.8
- Changed package path to gravity-devs/liquidity version for import Gaia
  
  https://github.com/Gravity-Devs/liquidity/releases/tag/v1.2.8

ref

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

zmanian · 2021-05-22T15:56:10Z

We need some handler code to initialize the keepers during the upgrade correct.

My mental model is we aren't doing a state dump during this upgrade and instead using the upgrade module functionality.

codecov · 2021-05-24T03:37:01Z

Codecov Report

Merging #859 (fd6bb72) into main (94a30c6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #859      +/-   ##
========================================
- Coverage   0.41%   0.39%   -0.02%     
========================================
  Files          7       7              
  Lines        483     505      +22     
========================================
  Hits           2       2              
- Misses       480     502      +22     
  Partials       1       1

dongsam · 2021-05-26T04:23:21Z

We need some handler code to initialize the keepers during the upgrade correct.

My mental model is we aren't doing a state dump during this upgrade and instead using the upgrade module functionality.

I'm currently writing the initializers code. I'll commit it within this week. Thank you for your comments.

app/app.go

dongsam · 2021-06-11T03:55:48Z

Hello, we are planning to finalize the Liquidity module by the 15th of June and release the version for Gaia. And I'll make it R4R.
You can find the progress on here

I'd like to hear your all opinion.
Currently REST endpoint path is using /tendermint/liquidity/v1beta1/* Liquidity Swagger
but for the consistency with cosmos-sdk modules It could be /cosmos/liquidity/v1beta1/* Comos Swagger

What do you think? here is the issue tendermint/liquidity#404
@zmanian @shahankhatch @Rose2161

zmanian · 2021-06-13T14:13:58Z

The rest path should be Cosmos

dongsam · 2021-06-14T01:39:14Z

The rest path should be Cosmos

Sure, Thanks for your opinion, Let me change it to /cosmos/liquidity/v1beta1/*

dongsam · 2021-06-16T07:59:02Z

The finalized version of liquidity module for Gaia is released https://github.com/tendermint/liquidity/releases/tag/v1.2.8
and above final codebase copied to https://github.com/Gravity-Devs/liquidity/releases/tag/v1.2.8 with changing package name from tendermint/liquidity to gravity-devs/liquidity and It applied on this PR

alexanderbez

🎉

app/app.go

aaronc · 2021-06-18T17:16:28Z

You all probably already know this, but this upgrade does need to be tested on an exported state of the cosmos hub on a devnet. Basically, the cosmos hub genesis needs to be exported, the validator set needs to be tweaked to run with just a few nodes and the voting window needs to be reduced to a few minutes. Then a trial run of this upgrade should be run with a few nodes running cosmovisor.

Hyung-bharvest · 2021-06-19T08:16:35Z

You all probably already know this, but this upgrade does need to be tested on an exported state of the cosmos hub on a devnet. Basically, the cosmos hub genesis needs to be exported, the validator set needs to be tweaked to run with just a few nodes and the voting window needs to be reduced to a few minutes. Then a trial run of this upgrade should be run with a few nodes running cosmovisor.

Yes I agree.

https://github.com/b-harvest/cosmoshub-3-testnet

This is not exactly what we need because the testnet was not for testing onchain upgrade, but it contains scripts for substituting validator keys for operation convenience. There exists several invariant check around validator info, so this should be helpful. Please reference it.

dongsam · 2021-06-20T07:01:51Z

You all probably already know this, but this upgrade does need to be tested on an exported state of the cosmos hub on a devnet. Basically, the cosmos hub genesis needs to be exported, the validator set needs to be tweaked to run with just a few nodes and the voting window needs to be reduced to a few minutes. Then a trial run of this upgrade should be run with a few nodes running cosmovisor.

Thank you for the suggestions and the review. @aaronc @alexanderbez
I will apply the code you suggested about multi-store with the upgrade testing using exported state of the cosmoshub-4 as soon as possible

I applied the code you suggested in the last commit.
The upgrade was successful based on the cosmosub-4 states with the applied code, and I will organize the details and share them again.

dongsam · 2021-06-22T06:44:37Z

We performed an upgrade test using the states of cosmoshub-4 through the binary version of the commit above to confirm that there was no problem with adding liquidity module

The script and procedure description and results used for the test are written on this repo

https://github.com/b-harvest/gravity-dex-upgrade-test

alexanderbez · 2021-06-22T12:30:21Z

Excellent write up @dongsam 👍

aaronc · 2021-06-22T12:45:17Z

Great!

shahankhatch · 2021-06-22T13:07:38Z

Excellent example of how to run an upgrade on a local machine. Very helpful for module development.
Amazing result too!

dongsam · 2021-06-23T05:59:03Z

I'm sorry for the additional commit after the review request.
There are no logical changes between liquidity version v1.2.8 and v1.2.7, but it includes adjusting default parameters of liquidity module and improving the test code's error check logic.

shahankhatch

Thank you for contributing this module! Great work!

Add Liquidity Module to Gaia

ff8528a

Rose2161 approved these changes May 23, 2021

View reviewed changes

dongsam mentioned this pull request May 30, 2021

Add handler code to initialize the keeper, states for upgrade module functionality tendermint/liquidity#367

Closed

4 tasks

dongsam added 2 commits May 31, 2021 11:59

Add upgrade handler for liquidity module

0ba00ae

Add preset of liquidity module genesis for gaia

c781741

zmanian reviewed Jun 3, 2021

View reviewed changes

app/app.go Show resolved Hide resolved

dongsam mentioned this pull request Jun 10, 2021

Gaia Gravity DEX upgrade simulation from cosmoshub-4 genesis tendermint/liquidity#403

Closed

4 tasks

dongsam added 2 commits June 10, 2021 13:39

Merge main branch into add-liquidity-module-to-gaia

674bb6e

update liquidity module version to v1.2.6-rc3

a4192c2

dongsam mentioned this pull request Jun 10, 2021

Decide whether to use tendermint or cosmos for Liquidity module REST endpoints tendermint/liquidity#404

Closed

8 tasks

dongsam added 2 commits June 16, 2021 16:20

change package path of liquidity module to gravity-devs/liquidity

b937517

Merge main into add-liquidity-module-to-gaia

e2c323b

dongsam marked this pull request as ready for review June 16, 2021 07:49

dongsam requested review from alessio, alexanderbez, jgimeno and shahankhatch as code owners June 16, 2021 07:49

alexanderbez mentioned this pull request Jun 16, 2021

Integrate the Gravity Bridge - Gravity Module umee-network/umee#2

Closed

zmanian approved these changes Jun 17, 2021

View reviewed changes

alexanderbez approved these changes Jun 17, 2021

View reviewed changes

app/app.go Show resolved Hide resolved

aaronc suggested changes Jun 18, 2021

View reviewed changes

app/app.go Show resolved Hide resolved

app/app.go Show resolved Hide resolved

app/app.go Show resolved Hide resolved

add set store logics for gravity-dex upgrade

022f6ee

aaronc approved these changes Jun 22, 2021

View reviewed changes

adjust genesis parameter of liquidity module

fd6bb72

dongsam requested a review from yaruwangway as a code owner June 23, 2021 05:56

shahankhatch approved these changes Jun 25, 2021

View reviewed changes

shahankhatch merged commit fe093ef into cosmos:main Jun 25, 2021

dongsam mentioned this pull request Jun 26, 2021

Bump sdk, tendermint version of liquidity module #891

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add liquidity module to gaia #859

Add liquidity module to gaia #859

dongsam commented May 20, 2021 •

edited

Loading

zmanian commented May 22, 2021

codecov bot commented May 24, 2021 •

edited

Loading

dongsam commented May 26, 2021

dongsam commented Jun 11, 2021

zmanian commented Jun 13, 2021 •

edited

Loading

dongsam commented Jun 14, 2021

dongsam commented Jun 16, 2021 •

edited

Loading

alexanderbez left a comment

aaronc commented Jun 18, 2021

Hyung-bharvest commented Jun 19, 2021 •

edited

Loading

dongsam commented Jun 20, 2021 •

edited

Loading

dongsam commented Jun 22, 2021 •

edited

Loading

alexanderbez commented Jun 22, 2021

aaronc commented Jun 22, 2021

shahankhatch commented Jun 22, 2021

dongsam commented Jun 23, 2021 •

edited

Loading

shahankhatch left a comment

Add liquidity module to gaia #859

Add liquidity module to gaia #859

Conversation

dongsam commented May 20, 2021 • edited Loading

Description

ref

zmanian commented May 22, 2021

codecov bot commented May 24, 2021 • edited Loading

Codecov Report

dongsam commented May 26, 2021

dongsam commented Jun 11, 2021

zmanian commented Jun 13, 2021 • edited Loading

dongsam commented Jun 14, 2021

dongsam commented Jun 16, 2021 • edited Loading

alexanderbez left a comment

Choose a reason for hiding this comment

aaronc commented Jun 18, 2021

Hyung-bharvest commented Jun 19, 2021 • edited Loading

dongsam commented Jun 20, 2021 • edited Loading

dongsam commented Jun 22, 2021 • edited Loading

alexanderbez commented Jun 22, 2021

aaronc commented Jun 22, 2021

shahankhatch commented Jun 22, 2021

dongsam commented Jun 23, 2021 • edited Loading

shahankhatch left a comment

Choose a reason for hiding this comment

dongsam commented May 20, 2021 •

edited

Loading

codecov bot commented May 24, 2021 •

edited

Loading

zmanian commented Jun 13, 2021 •

edited

Loading

dongsam commented Jun 16, 2021 •

edited

Loading

Hyung-bharvest commented Jun 19, 2021 •

edited

Loading

dongsam commented Jun 20, 2021 •

edited

Loading

dongsam commented Jun 22, 2021 •

edited

Loading

dongsam commented Jun 23, 2021 •

edited

Loading