Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reference tags localizable #2956

Closed
brandonkelly opened this issue Jun 4, 2018 · 7 comments
Closed

Make reference tags localizable #2956

brandonkelly opened this issue Jun 4, 2018 · 7 comments
Labels
content modeling 📓 features related to content modeling enhancement improvements to existing features

Comments

@brandonkelly
Copy link
Member

It should be possible to specify a site handle in a reference tag, so the element gets queried for the specified site.

Especially useful when storing a link to an entry for a specific site (e.g. #2945).

Possible syntax: {entry:123@siteHandle:url}.

@brandonkelly brandonkelly added enhancement improvements to existing features content modeling 📓 features related to content modeling labels Jun 4, 2018
@timkelty
Copy link
Contributor

timkelty commented Sep 17, 2018

Lots of other issues would be fixed with this.

While Craft core is concerned, it may be fair to consider this an "enhancement", but the resulting behavior from other plugins (e.g. Redactor) seems pretty buggy/broken:

@mattandrews
Copy link

I would like this feature – we sometimes need to insert links to pages from another locale (eg. "Click here to read this article in another language") and when saving these links, they get rewritten back to the original site.

I'm also not sure if this is related, but it seems that when I use the "Link to an entry" dialog from Redactor, switching sites/locales seems to have no effect on the content:

locales

If I view that same section via the Entries panel, I see:

locales2

(eg. those entries are definitely different between locales)

@timkelty
Copy link
Contributor

timkelty commented Mar 1, 2019

@mattandrews Correct, the site dropdown is broken in the craftcms/redactor.

@brandonkelly @andris-sevcenko is there a plan to address this (3.x vs 4.x)?

It is marked as a feature here, but it could resolve actual bugs in https://github.com/craftcms/redactor that have been around for a while now.

See:

@brandonkelly
Copy link
Member Author

We are planning on looking into this (and related #2854 and #3584 issues) for Craft 3.2.

@brandonkelly brandonkelly added this to the 3.2 milestone Mar 11, 2019
@davidhellmann
Copy link
Contributor

@mattandrews is that the same bug I've?
#4121

brandonkelly added a commit that referenced this issue May 24, 2019
@brandonkelly
Copy link
Member Author

Added for the next 3.2 Alpha release, using the @<Site> syntax shown in the original post. The site can be represented by its ID, UUID, or handle.

@mattandrews
Copy link

Incredible! Thanks so much 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content modeling 📓 features related to content modeling enhancement improvements to existing features
Projects
None yet
Development

No branches or pull requests

4 participants