Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs remain unparsed when requesting cross-site #92

Closed
timkelty opened this issue Sep 17, 2018 · 4 comments
Closed

Refs remain unparsed when requesting cross-site #92

timkelty opened this issue Sep 17, 2018 · 4 comments
Assignees

Comments

@timkelty
Copy link
Contributor

Example:

myRedactorField contains a link to an element on siteA (e.g. <a href=\"{entry:2581:url}\">)

Twig template text.twig:

{% set entry = craft.entries({site: "siteA", id: 123}).one() %}
{{ entry.myRedactorField }}

Now request siteB.com/test.twig.
The content is returned with the link ref unparsed.

Same issue:
markhuot/craftql#157

@timkelty
Copy link
Contributor Author

timkelty commented Sep 17, 2018

It seems that the siteId from the entry selection needs to be passed along here, but is not: https://github.com/craftcms/redactor/blob/v2/src/FieldData.php#L47

However, since I don't think the siteId is saved as part of the ref, this may be a larger, more systemic issue…

@timkelty
Copy link
Contributor Author

Related: #53

timkelty pushed a commit to timkelty/redactor that referenced this issue Oct 2, 2018
@andris-sevcenko andris-sevcenko self-assigned this Oct 26, 2018
@andris-sevcenko
Copy link
Contributor

No action at the time, waiting for this to be fixed on Craft level.

@brandonkelly
Copy link
Member

This is resolved in Redactor 2.5 thanks to @steverowling’s PR! (2.5 requires Craft 3.4 RC1+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants