Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site selection not working in link dialog #53

Closed
jacksutherland opened this issue May 17, 2018 · 9 comments · Fixed by #187
Closed

Site selection not working in link dialog #53

jacksutherland opened this issue May 17, 2018 · 9 comments · Fixed by #187
Assignees

Comments

@jacksutherland
Copy link

jacksutherland commented May 17, 2018

I have a multi-site set up, with a different language for each site. In my redactor rich text editor, I need to create links to entries from a different site/language. However when I change the site/language in the drop down, the entries for that site/language do not display... It only shows the entries for whatever the current site is. See screenshot.

image

Steps to reproduce:

  1. Create 2 or more sites
  2. Add entries to both.
  3. Add a redactor field to an entry.
  4. Edit entry, add text to rtf
  5. select text and click hyperlink button
  6. change site in site drop down
    7... Entries do not change for the site selected
@andris-sevcenko andris-sevcenko self-assigned this May 18, 2018
@andris-sevcenko
Copy link
Contributor

In reality the site dropdown should not be there at all, because reference tags do not support specifying the site yet, so if you could select an entry from a different site, it would lead to unpredictable behavior.

Before this is addressed we must add support for specifying site in reference tags.

Keeping this open as this is a feature I think Redactor should have once requirements are in place, but meanwhile you're stuck using hardcoded URLs.

@jacksutherland
Copy link
Author

I think it would be useful to be able to select an entry from another site within the same craft instance, as often the sites are related in this scenario. However if not, then the drop down should be hidden, because my clients are confused by it... If it's there people are going to try to use it.

@andris-sevcenko
Copy link
Contributor

I agree with that but that's impossible until Craft reference tags support specifying the site as well. If an entry is present in two sites, it still has just one entry id, so, unless the site is also specified, Craft would have no idea which entry should be displayed.

The immediate solution is to remove the dropdown and, once reference tags support site, allow selecting the site.

@timkelty
Copy link
Contributor

Before this is addressed we must add support for specifying site in reference tags.

This was just added to 3.2! craftcms/cms#2956
Hoping we can now see this fixed in Redactor.

/cc @andris-sevcenko

@tomastech
Copy link

I am seeing a similar issue, except it's when pulling in redactor field from site A entry to site B via entries field (craft 3.2.0-beta.1).

Site A entry with a redactor field has a link to another entry within Site A. When site A field is rendered on site B, it shows up unprocessed (i.e. {entry:2:url} ).

@gregkohn
Copy link

@andris-sevcenko Thanks for your explanation above. Any word on when this will be fixed?

@steverowling
Copy link
Contributor

steverowling commented Dec 6, 2019

@andris-sevcenko Any news on when this might be fixed to allow linking to entries across sites in multi-site installs from within a Redactor field?

andris-sevcenko added a commit that referenced this issue Dec 11, 2019
…nking

- Add ability to link to entries in different sites
- Fix #53
- Fix #92
@brandonkelly
Copy link
Member

This is resolved in Redactor 2.5 thanks to @steverowling’s PR! (2.5 requires Craft 3.4 RC1+)

@timkelty
Copy link
Contributor

timkelty commented Jan 18, 2020

Great work @steverowling!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants