DAOSGCP-77 Merge v0.1.0 changes from develop to main #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DAOS-9910 pre-commit hooks Added configuration files for pre-commit tflint tfdocs Added tools/autodoc/terraform_docs.sh which is also used in HPC Toolkit to auto generate documentation in README.md for terraform modules. Added docs/development.md which contains information about installing pre-commit and dependencies and how to install the pre-commit hooks. Added link to docs/development.md on the main readme Signed-off-by: Mark A. Olson <[email protected]> * DAOS-9910 Remove the word OPTIONAL For MacOS users it's not optional to install findutils and coreutils. The pre-commit hooks in this repo do not work on MacOS unless those packages are installed. Therefore we need to remove the word OPTIONAL. Signed-off-by: Mark A. Olson <[email protected]> * DAOS-9910 Removed duplicate README content Also fixed tflint command in docs/development.md Signed-off-by: Mark A. Olson <[email protected]> * DAOS-9910 Update to fix missing Setup section Signed-off-by: Mark A. Olson <[email protected]>
Removed server and client config .yaml files from the images directory. Config files are no longer added in the images and expected to be modified when the instances start. Config files are now templates in terraform. The templates are rendered and added to metadata values for each instance. Then a startup script is used to get the content of the metadata values and save it to the config doas_*.yml files. This allows settings such as nr_hugepages, targets, scm_size in the config files to be set properly based on the terraform variables. The daos_server terraform module now has an output value named access_points that contains a list of the access points needed for the daos_agent.yml and daos_control.yml on the clients. Signed-off-by: Mark A. Olson <[email protected]>
Signed-off-by: Łukasz Sitkiewicz <[email protected]>
* DAOSGCP-80 Add functionality to propagate SSH keys to all nodes Signed-off-by: Łukasz Sitkiewicz <[email protected]> * Change pdsh to clush Signed-off-by: Łukasz Sitkiewicz <[email protected]>
Signed-off-by: Łukasz Sitkiewicz <[email protected]>
1. Renamed example directories for clarity and consistency 2. Updated variable names in examples to be consistent 3. Added terraform.tfvars.*.example files. Updated variable values in terraform.tfvars.*.example files This takes care of the changes required for DAOSGCP-76 4. Updated main README.md to contain more instructions for getting started 5. Created Cloud Shell tutorial that walks through the one-time setup steps 6. Created Cloud Shell tutorial that walks through the daos_cluster example 7. Set default DAOS version to 2.0 Signed-off-by: Mark A. Olson <[email protected]>
cboneti
approved these changes
Mar 30, 2022
johannlombardi
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging changes for v0.1.0 from develop to main