Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GRPC client #36

Open
withinboredom opened this issue Jan 29, 2021 · 3 comments · May be fixed by #91
Open

Add GRPC client #36

withinboredom opened this issue Jan 29, 2021 · 3 comments · May be fixed by #91
Assignees
@withinboredom
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@withinboredom
Copy link
Contributor

Describe the feature

Dapr supports GPRC which the PHP SDK could benefit from.

Release Note

RELEASE NOTE: ADD GPRC client
@withinboredom withinboredom self-assigned this Jan 29, 2021
@withinboredom withinboredom added the enhancement New feature or request label Jan 29, 2021
@withinboredom withinboredom added this to the 1.0.0 milestone Jan 29, 2021
@withinboredom withinboredom mentioned this issue Feb 2, 2021
Merged
3 tasks
@withinboredom withinboredom changed the title Add GPRC client Add GRPC client Feb 4, 2021
@withinboredom withinboredom removed this from the 1.0.0 milestone Feb 12, 2021
@withinboredom
Copy link
Contributor Author

Currently waiting for 1.36 to be released of grpc/grpc, though I do have a functioning local branch that uses 1.35. gRPC is going to be interesting and increases the test surface area considerably.

It appears you'd have to have the grpc/protobuf extensions installed even if you want to only use the REST API of Dapr which is disappointing. I'm hoping to figure out some way around that, likely by providing a separate package.

@withinboredom withinboredom added this to the v2.0.0 milestone Mar 9, 2021
@litan1106
Copy link

Looking for this GRPC feature

@withinboredom
Copy link
Contributor Author

It's coming @litan1106, this is my highest priority item and I'd like to see it ready for production by the end of May.

@withinboredom withinboredom linked a pull request May 15, 2021 that will close this issue
Open
3 tasks
This was referenced Jun 10, 2021
Merged
Closed
This was referenced Jul 16, 2021
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 24, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@withinboredom withinboredom

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

WIP: Generated clients for HTTP and GRPC dapr/php-sdk
2 participants
@litan1106 @withinboredom