Review baby hero test #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saidashacl.cpp: In function 'sai_status_t sai_create_dash_acl_group(sai_object_id_t*, sai_object_id_t, uint32_t, const sai_attribute_t*)':
saidashacl.cpp:96:21: warning: invalid conversion from 'sai_object_id_t*' {aka 'long unsigned int*'} to 'sai_object_id_t' {aka 'long unsigned int'} [-fpermissive]
RemoveFromTable(dash_acl_group_id);
^~~~~~~~~~~~~~~~~
In file included from saidashacl.cpp:9:
utils.h:227:38: note: initializing argument 1 of 'bool RemoveFromTable(sai_object_id_t)'
bool RemoveFromTable(sai_object_id_t id);
~~~~~~~~~~~~~~~~^~
saidashacl.cpp: In function 'sai_status_t sai_create_dash_acl_rule(sai_object_id_t*, sai_object_id_t, uint32_t, const sai_attribute_t*)':
saidashacl.cpp:828:21: warning: invalid conversion from 'sai_object_id_t*' {aka 'long unsigned int*'} to 'sai_object_id_t' {aka 'long unsigned int'} [-fpermissive]
RemoveFromTable(dash_acl_rule_id);
^~~~~~~~~~~~~~~~
In file included from saidashacl.cpp:9:
utils.h:227:38: note: initializing argument 1 of 'bool RemoveFromTable(sai_object_id_t)'
bool RemoveFromTable(sai_object_id_t id);
~~~~~~~~~~~~~~~~^~
saidasheni.cpp: In function 'sai_status_t sai_create_eni(sai_object_id_t*, sai_object_id_t, uint32_t, const sai_attribute_t*)':
saidasheni.cpp:376:21: warning: invalid conversion from 'sai_object_id_t*' {aka 'long unsigned int*'} to 'sai_object_id_t' {aka 'long unsigned int'} [-fpermissive]
RemoveFromTable(eni_id);
^~~~~~
In file included from saidasheni.cpp:9:
utils.h:227:38: note: initializing argument 1 of 'bool RemoveFromTable(sai_object_id_t)'
bool RemoveFromTable(sai_object_id_t id);
~~~~~~~~~~~~~~~~^~
saidashvnet.cpp: In function 'sai_status_t sai_create_vnet(sai_object_id_t*, sai_object_id_t, uint32_t, const sai_attribute_t*)':
saidashvnet.cpp:96:21: warning: invalid conversion from 'sai_object_id_t*' {aka 'long unsigned int*'} to 'sai_object_id_t' {aka 'long unsigned int'} [-fpermissive]
RemoveFromTable(vnet_id);
^~~~~~~
In file included from saidashvnet.cpp:9:
utils.h:227:38: note: initializing argument 1 of 'bool RemoveFromTable(sai_object_id_t)'
bool RemoveFromTable(sai_object_id_t id);
~~~~~~~~~~~~~~~~^~
Signed-off-by: Ze Gan <[email protected]>
Generate ADDR_FAMILY attribute to object types that have IP address as part of it's key. This is a read-only attribute used by resource availability API. Signed-off-by: Marian Pritsak <[email protected]>
* Update sdn-pipeline-basic-elements.md Added VNET Peering and VNET Global Peering information * Update documentation/general/sdn-pipeline-basic-elements.md Fix spelling
- Added a new option to set exact test target name - Added a new option to control traffic direction in tests - Updated skipifs Signed-off-by: Yuriy Harhas <[email protected]>
* Starting a series of tutorials using SAI CHallenger. * Spellcheck * README * Add vnet tutorial file * Run all saic tests not just vnet. * Added to SAIC tutorial. * Spellcheck * Organize test saic directory and readmes. * Spellcheck * Spellcheck * Spellcheck * reorganize docs * spellcheck * Tutorial progress. * tutorial progress, plus SAIC testb ed docs * Tutorials, saic testbed * SAIC testbed readme * spellcheck * Spellcheck, polish. * Spellcheck * Tutorial test cases and docs. * Tutorials. * spellcheck * Polishing tutorials. * Add assertions and result printing. * Fix assertions * Improve printing of results. * Fix stale info in SAI CHallenger docs per review feedback. * workflow documentation. * Simplify dpugen example. * Update SAI challenger testbed diagram; add diagrams for SAI Challenger tutorials. * Move SAIChallenger tutorials to functional test directory instead of scale. * Updated SAI-C related scripts as per changes in SAI-C repo Signed-off-by: Andriy Kokhan <[email protected]> * Update branch name in .gitmodules Signed-off-by: Andriy Kokhan <[email protected]> * Initialize SAI-C submodules from Makefile Signed-off-by: Andriy Kokhan <[email protected]> * Revert "Initialize SAI-C submodules from Makefile" This reverts commit 5196002. * Fixed DASH check for SAI-C * Updated SAI-C submodule to main branch Signed-off-by: Andriy Kokhan <[email protected]> * Re-worked SAI-C target build Signed-off-by: Andriy Kokhan <[email protected]> * Updated SAI-C TB description files Signed-off-by: Andriy Kokhan <[email protected]> Signed-off-by: Andriy Kokhan <[email protected]> Co-authored-by: Chris Sommers <[email protected]> Co-authored-by: Andriy Kokhan <[email protected]>
* Added new test plans for VNET to VNET testing * Incorporated changes recommended * Updated link to SONiC test plan template The recommendation was to de-duplicate the SONiC test plan template and referenced it to its original placeholder * Deleting the SONiC test plan template Removing the test plan template as the link to it is provided in the README file * Linked to the original VNET-to-VNET-service doc Removed the diagram and referenced to the original VNET service document under DASH documentation * Removed vm-to-vm-communication-vnet.svg Since the original document is reference, no need for the VM to VM communication svg file here * Fixed the VNET service link rectified the incorrect VNET service link to reflect the correct one * Fixed typos Rectified some typos in the document * Fixed the image in Test plan document
* Update config file * Changed GitHub URLs per move from Azure/DASH to sonic-net/DASH. grep -rnl --include=*.py --include=*.md --include=*.svg 'github.com/Azure/DASH'|xargs sed -i -e 's.Azure/DASH.sonic-net/DASH.g'
* [Sonic HLD] Metering requirements
…c-net#309) * Dash-Sonic - Update for Scaling/Underlay Routing
Added EasyCLA and ICLA
* Adding SAI api tests for CRUD operation (#4) * Adding SAI api tests for CRUD operation * Cleanup import and fix assert statements * Undo gitignore changes * Update .gitignore * Update .gitignore * Skip get and set tests, not implemented yet * Add dependency tests for VNET In Route test * Fixed some dependency tests * Run all SAIC tests, not just vnet. (#5) * Run all SAIC tests, not just vnet. * Change name of test script. Co-authored-by: Chris Sommers <[email protected]> Co-authored-by: Chris Sommers <[email protected]> Co-authored-by: Chris Sommers <[email protected]> * Incorporated changes from feedback from community 1. Updated assert statements to remove false pass 2. Added setup and cleanup to ensure tests pass independently 3. Skip get/set tests because feature not available yet in BMv2 4. Inbound route for the ACL test is skipped due to issue sonic-net#233 * remove unneeded files * Incorporated requested changes Logging and dependencies in tests will be implemented in another PR. Implemented the remaining changes requested --------- Co-authored-by: Chris Sommers <[email protected]> Co-authored-by: Chris Sommers <[email protected]>
* Update README.md Updating to reflect LF EasyCLA information * Update .wordlist.txt
Change this to 32M (each way)?
* [Sonic] Update on scaling limits
* Update dash-sonic-hld.md: Fixed minor index error.
) * Add #ifdef's so P4 code can target BMv2 or DPDK back ends You should define the symbol ARCH_BMV2_V1MODEL to compile for BMv2, or define the symbol ARCH_DPDK_PNA to compile for DPDK. * Add new preprocessor define symbol to p4c command line for P4 code * Added tooling for p4c-dpdk compiler backend: dockerfiles, git CI files, makefile targets. This is experimental and uses the p4c-dpdk backend from dockerhub p4lang/p4c:latest. It attempts to compile the unmofidied bmv2 P4 source for DASH, not the experimetnally-modified code created by Andy F. under dpdk-pna/. Output artifacts are stored under dpdk-pna/dash_pipeline.dpdk. * Add dockerfiles, CI and Make targets for p4-dpdk target. * Rename ARCH_* preprocessor symbols as TARGET_* * Replace copy-and-pasted occurrence of bmv2 with DPDK --------- Co-authored-by: Chris Sommers <[email protected]>
Signed-off-by: Taras Keryk <[email protected]>
fix sonic-net#342 Changes string "Azure/DASH" to "sonic-net/DASH" in CI files, which allows them to publish docker images to ACR. This silent failure was caused by repo migration without considering the side-effects. Also changes a few more locations in .md and .svg files. This was missed in PR sonic-net#321 which looked for the string "github.com/Azure/DASH" which missed some occurrences.
Signed-off-by: Anton Putria <[email protected]>
* committing outbound testcases * committing outbound testcases (#12) * pushing vnet hepler file to utils folder * Added dependency * Adding xfail with issue 236 * Addressed Anton comment
- Metering Policy, rule and meter schemas - Adding pipeline diagram for outbound meter
* [Sonic] PL on NSG and Inbound flows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.