feat(nns): Added Neuron::voting_power_refreshed_timestamp_seconds field. #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
changed the title
daniel-wong-dfinity-org
changed the title
LaraAS
reviewed
Oct 28, 2024
aterga
reviewed
Oct 28, 2024
rs/nns/governance/proto/ic_nns_governance/pb/v1/governance.proto
Outdated
Show resolved
Hide resolved
aterga
reviewed
Oct 30, 2024
aterga
reviewed
Oct 30, 2024
aterga
reviewed
Oct 30, 2024
aterga
approved these changes
Oct 30, 2024
daniel-wong-dfinity-org
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
This occurs when a neuron is modified in the following ways: 1. vote (directly, not indirectly) 2. change follow # Background This is part of the "periodic confirmation" feature that was recently approved in proposal [132411][prop]. [prop]: https://dashboard.internetcomputer.org/proposal/132411 # Future Work This will be used to reduce the voting power in ballots when a neuron has not refreshed for a long time. # References Closes https://dfinity.atlassian.net/browse/NNS1-3405. [👈 Previous PR][prev] | [Next PR 👉][next] [prev]: #2268 [next]: #2338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new neuron, this field gets set to the same value as created_timestamp_seconds.
For existing neurons, they will be treated as though the value in this field is 1 second after midnight 2024-11-05 UTC (until they refresh).
Background
This is part of the "periodic confirmation" feature that was recently approved in proposal 132411.
Future Work
The value in this field will get updated to the current time whenever the user performs "relevant" operations.
References
Closes https://dfinity.atlassian.net/browse/NNS1-3404.
Next PR 👉