Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nns): Refresh voting power. #2320

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

daniel-wong-dfinity-org
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Oct 29, 2024

This occurs when a neuron is modified in the following ways:

  1. vote (directly, not indirectly)
  2. change follow

Background

This is part of the "periodic confirmation" feature that was recently approved in proposal 132411.

Future Work

This will be used to reduce the voting power in ballots when a neuron has not refreshed for a long time.

References

Closes https://dfinity.atlassian.net/browse/NNS1-3405.

👈 Previous PR | Next PR 👉

Copy link
Contributor Author

@daniel-wong-dfinity-org daniel-wong-dfinity-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help for reviewers.

rs/nns/governance/src/lib.rs Show resolved Hide resolved
@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as ready for review October 30, 2024 14:51
@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner October 30, 2024 14:51
@daniel-wong-dfinity-org daniel-wong-dfinity-org force-pushed the refresh-voting-power-daniel-wong branch from dfd0570 to 58abee2 Compare October 30, 2024 16:12
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2024
…ld. (#2268)

When creating a new neuron, this field gets set to the same value as
created_timestamp_seconds.

For existing neurons, they will be treated as though the value in this
field is 1 second after midnight 2024-11-05 UTC (until they refresh).

In a later PR, the value in this field will get updated to the current
time whenever the user performs "relevant" operations.

Closes https://dfinity.atlassian.net/browse/NNS1-3404.

[Next PR 👉][next]

[next]: #2320
Base automatically changed from following_refreshed-daniel-wong to master October 30, 2024 18:40
@anchpop anchpop added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit a52f966 Oct 31, 2024
32 checks passed
@anchpop anchpop deleted the refresh-voting-power-daniel-wong branch October 31, 2024 18:34
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2024
This was spun out of sns governance so that it can be used elsewhere (in
another PR that I'm working on).

# References

(No ticket.)

[👈 Previous PR][prev] | [Next PR 👉][next]

[prev]: #2320
[next]: #2339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants