-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nns): Refresh voting power. #2320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
changed the base branch from
master
to
following_refreshed-daniel-wong
October 29, 2024 19:08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help for reviewers.
Merged
daniel-wong-dfinity-org
force-pushed
the
refresh-voting-power-daniel-wong
branch
from
October 30, 2024 16:12
dfd0570
to
58abee2
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
…ld. (#2268) When creating a new neuron, this field gets set to the same value as created_timestamp_seconds. For existing neurons, they will be treated as though the value in this field is 1 second after midnight 2024-11-05 UTC (until they refresh). In a later PR, the value in this field will get updated to the current time whenever the user performs "relevant" operations. Closes https://dfinity.atlassian.net/browse/NNS1-3404. [Next PR 👉][next] [next]: #2320
daniel-wong-dfinity-org
force-pushed
the
refresh-voting-power-daniel-wong
branch
from
October 30, 2024 21:05
58abee2
to
445eca4
Compare
anchpop
reviewed
Oct 31, 2024
max-dfinity
reviewed
Oct 31, 2024
max-dfinity
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurs when a neuron is modified in the following ways:
Background
This is part of the "periodic confirmation" feature that was recently approved in proposal 132411.
Future Work
This will be used to reduce the voting power in ballots when a neuron has not refreshed for a long time.
References
Closes https://dfinity.atlassian.net/browse/NNS1-3405.
👈 Previous PR | Next PR 👉