feat: Linear map. #2338
Merged
feat: Linear map. #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
force-pushed
the
linear-map-daniel-wong
branch
from
073e084 to
2ea1a92
Compare
daniel-wong-dfinity-org
changed the base branch from
master
to
refresh-voting-power-daniel-wong
daniel-wong-dfinity-org
force-pushed
the
refresh-voting-power-daniel-wong
branch
from
dfd0570 to
58abee2
Compare
daniel-wong-dfinity-org
force-pushed
the
linear-map-daniel-wong
branch
from
9c32f4d to
3a989bb
Compare
max-dfinity
reviewed
Oct 30, 2024
daniel-wong-dfinity-org
force-pushed
the
refresh-voting-power-daniel-wong
branch
from
58abee2 to
445eca4
Compare
daniel-wong-dfinity-org
force-pushed
the
linear-map-daniel-wong
branch
from
3a989bb to
98e5605
Compare
max-dfinity
approved these changes
Oct 31, 2024
daniel-wong-dfinity-org
force-pushed
the
linear-map-daniel-wong
branch
from
740b692 to
50aca63
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
This occurs when a neuron is modified in the following ways: 1. vote (directly, not indirectly) 2. change follow # Background This is part of the "periodic confirmation" feature that was recently approved in proposal [132411][prop]. [prop]: https://dashboard.internetcomputer.org/proposal/132411 # Future Work This will be used to reduce the voting power in ballots when a neuron has not refreshed for a long time. # References Closes https://dfinity.atlassian.net/browse/NNS1-3405. [👈 Previous PR][prev] | [Next PR 👉][next] [prev]: #2268 [next]: #2338
daniel-wong-dfinity-org
force-pushed
the
linear-map-daniel-wong
branch
from
50aca63 to
85f80ec
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
…er. (#2339) Add deciding_voting_power method to Neuron. Renames the voting_power method of Neuron to potential_voting_power. Added a flag that controls whether deciding_voting_power applies adjustment. Per usual, adjustment is off in vanilla builds, but on when feature = "test". Voting rewards uses this new method. As long as the the new behavior is not enabled (via the flag), this should result in no behavior change, and even initially, when the feature is enabled, since no neuron can be too unrefreshed, even then, there would be no immediate behavior change. # Background This is part of the "periodic confirmation" feature that was recently approved in proposal [132411][prop]. [prop]: https://dashboard.internetcomputer.org/proposal/132411 # References Closes https://dfinity.atlassian.net/browse/NNS1-3406, https://dfinity.atlassian.net/browse/NNS1-3407. [👈 Previous PR][prev] | [Next PR 👉][next] [prev]: #2338 [next]: #2375
alin-at-dfinity
pushed a commit
that referenced
this pull request
Nov 7, 2024
…er. (#2339) Add deciding_voting_power method to Neuron. Renames the voting_power method of Neuron to potential_voting_power. Added a flag that controls whether deciding_voting_power applies adjustment. Per usual, adjustment is off in vanilla builds, but on when feature = "test". Voting rewards uses this new method. As long as the the new behavior is not enabled (via the flag), this should result in no behavior change, and even initially, when the feature is enabled, since no neuron can be too unrefreshed, even then, there would be no immediate behavior change. # Background This is part of the "periodic confirmation" feature that was recently approved in proposal [132411][prop]. [prop]: https://dashboard.internetcomputer.org/proposal/132411 # References Closes https://dfinity.atlassian.net/browse/NNS1-3406, https://dfinity.atlassian.net/browse/NNS1-3407. [👈 Previous PR][prev] | [Next PR 👉][next] [prev]: #2338 [next]: #2375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was spun out of sns governance so that it can be used elsewhere (in another PR that I'm working on).
References
(No ticket.)
👈 Previous PR | Next PR 👉