Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade XStream Lib #21060

Closed
wezell opened this issue Sep 22, 2021 · 11 comments · Fixed by #22187 or #26936
Closed

Upgrade XStream Lib #21060

wezell opened this issue Sep 22, 2021 · 11 comments · Fixed by #22187 or #26936
Labels
OKR : Security & Privacy Owned by Mehdi Priority : 2 High QA : Approved QA : Passed Internal Release : 24.02.20 New binary field, AI plugin Team : Scout Type : Enhancement

Comments

@wezell
Copy link
Contributor

wezell commented Sep 22, 2021 •
edited by sfreudenthaler
Loading

The new XStream lib takes a whitelist of objects that it can deserialize - we need to

  • upgrade to the latest version
  • generate a working whitelist for the classes we expect to serialize / deserialize
  • create a single XStreamProvider to get one XStream instance and use it everywhere

Testing includes starter generation / importing and push publishing

Patching this closes a significant batch of dependabot crits
@wezell wezell added this to the Falcon Current milestone Sep 22, 2021
@wezell wezell modified the milestones: Falcon Current, Maintenance Sprint Oct 5, 2021
@wezell wezell mentioned this issue Oct 5, 2021
Closed
@dsilvam dsilvam removed this from the Maintenance Sprint milestone Oct 25, 2021
@freddyucv freddyucv self-assigned this May 9, 2022
freddyucv pushed a commit that referenced this issue May 10, 2022
@freddyDOTCMS
#21060 Create the XStreamFactory
933a657
@freddyucv freddyucv mentioned this issue May 10, 2022
Merged
freddyucv pushed a commit that referenced this issue May 10, 2022
@freddyDOTCMS
#21060 Using XStreamFactory everywhere
eeaed79
@wezell
Copy link
Contributor Author

wezell commented May 11, 2022

We need to go to 1.4.19

dsilvam pushed a commit that referenced this issue May 12, 2022
@freddyDOTCMS
#21060 Create the XStreamFactory (#22187)
66c7fb3 
* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* Add test in MainSuite

* Add test in MainSuite

* remove unnecessary change
@dsilvam dsilvam linked a pull request May 12, 2022 that will close this issue
#21060 Create the XStreamFactory #22187
Merged
dsilvam pushed a commit that referenced this issue May 26, 2022
@freddyDOTCMS
#21060 Using XStreamFactory everywhere (#22192)
01495e1 
* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* #21060 Using XStreamFactory everywhere

* Just testing

* Testing

* Testing

* testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Fxing test

* Fixing test
@dsilvam
Copy link
Contributor

dsilvam commented May 27, 2022

PR ee: https://github.com/dotCMS/enterprise/pull/875

dsilvam pushed a commit that referenced this issue Jun 1, 2022
@freddyDOTCMS @alfredo-dotcms
@fabrizzio-dotCMS @jdotcms @nollymar @wezell @fmontes
#22250 Moving unique per site to field variable (#22304)
b65ec66 
* #22131 fix show-or-hide-ViewStatistics-button-based-on-dotmarketing-property (#22201)

* #22073 adding test for AWSS3Publisher (#22200)

* #21060 Create the XStreamFactory (#22187)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* Add test in MainSuite

* Add test in MainSuite

* remove unnecessary change

* #21626 Container Resource (#21455)

* #2142 adding first draft

* #21432 optimizing the get link

* #21432 optimizing the get link2

* #21432 adding postman test

* #21432 adding template test

* #21432 first draft container

* adding unpublish

* #21432 unpublish container

* #21432 added save new container endpoint

* #21432 adding container bring back + curl test

* #21432 adding container bring back + curl test

* #21432 adding the methods for all containers operations

* #21432 adding first curl test for containers

* #21432 adding container publish/unpublish

* #21432 more container enhancements

* #21432 adding publish and unpublish for file container

* #21432 adding the archive functionality

* #21432 adding changes for retrieving archive file container

* #21432 adding the unarchive function

* #21432 added delete container

* #21432 clean up

* #21432 test and final changes to the container resource

* #21432 adding some fixes to the container curl test

* #21432 adding more curl test per feedback

* #21432 fixing curl test

* #21432 fixing curl test part 2

* #21432 finally fixed the curl test for containers

* #21432 fixing the curl test

* #21432 changes over the curl test

* #21432 adding a change to remove the container/test folder is exists and run the test from fresh

* #21432 adding more curl test

* #21432 adding PR feedback

* Targeting master as branch

* Validatee if exists a Vanity URL Contet Type with a site Custom field (#22232)

* #22186 The minSelections was modified to avoid refreshing screen without selecting a country (#22243)

Co-authored-by: nollymar <[email protected]>

* #22007 fixes rewrites when its a urlmap (#22142)

Co-authored-by: nollymar <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>

* Removing Task220404RemoveCalendarReminderTest

* #22250 Moving unique oer site to field variable

* #21060 Using XStreamFactory everywhere (#22192)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* #21060 Using XStreamFactory everywhere

* Just testing

* Testing

* Testing

* testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Fxing test

* Fixing test

* Removing ;

* refactoring

* Fixing test

* Revert "Fixing test"

This reverts commit 1541ff7.

* Revert "Revert "Fixing test""

This reverts commit 1bcee19.

* Revert "Merge remote-tracking branch 'origin/master' into issue-22250-Move-Unique-per-site-to-a-field-variable"

This reverts commit 82edb94, reversing
changes made to 1541ff7.

Co-authored-by: alfredo-dotcms <[email protected]>
Co-authored-by: Fabrizzio Araya <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: nollymar <[email protected]>
Co-authored-by: Nollymar Longa <[email protected]>
Co-authored-by: Will Ezell <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>
Co-authored-by: Freddy Montes <[email protected]>
freddyucv pushed a commit that referenced this issue Jun 10, 2022
@freddyDOTCMS
#21060 Fixing test and refactoring
5031b03
freddyucv pushed a commit that referenced this issue Jun 10, 2022
@freddyDOTCMS
#21060 merge
3103ee7
freddyucv pushed a commit that referenced this issue Jun 10, 2022
@freddyDOTCMS
#21060 renaming method
c94518c
oidacra pushed a commit that referenced this issue Jun 13, 2022
@freddyDOTCMS @alfredo-dotcms
@fabrizzio-dotCMS @jdotcms @nollymar @wezell @fmontes @oidacra
#22250 Moving unique per site to field variable (#22304)
7cc892d 
* #22131 fix show-or-hide-ViewStatistics-button-based-on-dotmarketing-property (#22201)

* #22073 adding test for AWSS3Publisher (#22200)

* #21060 Create the XStreamFactory (#22187)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* Add test in MainSuite

* Add test in MainSuite

* remove unnecessary change

* #21626 Container Resource (#21455)

* #2142 adding first draft

* #21432 optimizing the get link

* #21432 optimizing the get link2

* #21432 adding postman test

* #21432 adding template test

* #21432 first draft container

* adding unpublish

* #21432 unpublish container

* #21432 added save new container endpoint

* #21432 adding container bring back + curl test

* #21432 adding container bring back + curl test

* #21432 adding the methods for all containers operations

* #21432 adding first curl test for containers

* #21432 adding container publish/unpublish

* #21432 more container enhancements

* #21432 adding publish and unpublish for file container

* #21432 adding the archive functionality

* #21432 adding changes for retrieving archive file container

* #21432 adding the unarchive function

* #21432 added delete container

* #21432 clean up

* #21432 test and final changes to the container resource

* #21432 adding some fixes to the container curl test

* #21432 adding more curl test per feedback

* #21432 fixing curl test

* #21432 fixing curl test part 2

* #21432 finally fixed the curl test for containers

* #21432 fixing the curl test

* #21432 changes over the curl test

* #21432 adding a change to remove the container/test folder is exists and run the test from fresh

* #21432 adding more curl test

* #21432 adding PR feedback

* Targeting master as branch

* Validatee if exists a Vanity URL Contet Type with a site Custom field (#22232)

* #22186 The minSelections was modified to avoid refreshing screen without selecting a country (#22243)

Co-authored-by: nollymar <[email protected]>

* #22007 fixes rewrites when its a urlmap (#22142)

Co-authored-by: nollymar <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>

* Removing Task220404RemoveCalendarReminderTest

* #22250 Moving unique oer site to field variable

* #21060 Using XStreamFactory everywhere (#22192)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* #21060 Using XStreamFactory everywhere

* Just testing

* Testing

* Testing

* testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Fxing test

* Fixing test

* Removing ;

* refactoring

* Fixing test

* Revert "Fixing test"

This reverts commit 1541ff7.

* Revert "Revert "Fixing test""

This reverts commit 1bcee19.

* Revert "Merge remote-tracking branch 'origin/master' into issue-22250-Move-Unique-per-site-to-a-field-variable"

This reverts commit 82edb94, reversing
changes made to 1541ff7.

Co-authored-by: alfredo-dotcms <[email protected]>
Co-authored-by: Fabrizzio Araya <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: nollymar <[email protected]>
Co-authored-by: Nollymar Longa <[email protected]>
Co-authored-by: Will Ezell <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>
Co-authored-by: Freddy Montes <[email protected]>
nollymar added a commit that referenced this issue Jan 17, 2024
@nollymar
#21060 Adding a single point of entry when creating xstream instances
7bdfc44
@nollymar nollymar moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jan 17, 2024
nollymar added a commit that referenced this issue Jan 22, 2024
@nollymar
#21060 Fixing Sonar issues
2e26221
@nollymar nollymar moved this from In Progress to In Review in dotCMS - Product Planning Jan 22, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2024
@nollymar
Upgrading xstream to version 1.4.20 (#26936)
b8d4504 
* Upgrading xstream to version 1.4.20

* #21060 Fixing ITs

* Fixing typo

* #21060 Temporarily allowing any permission and logging it to help in a white list creation

* #21060 Adding a single point of entry when creating xstream instances

* #21060 Fixing Sonar issues
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Jan 23, 2024
@nollymar nollymar reopened this Jan 23, 2024
@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Jan 23, 2024
@nollymar nollymar removed their assignment Jan 23, 2024
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jan 23, 2024
@sfreudenthaler
Copy link
Contributor

Great to see the code merged here. Is it waiting qa from @bryanboza or from security (@mbiuki)?

@nollymar
Copy link
Contributor

@sfreudenthaler this card is on internal QA

@fabrizzio-dotCMS fabrizzio-dotCMS removed their assignment Jan 30, 2024
@fabrizzio-dotCMS
Copy link
Contributor

On a second review and after having squared away local environmental issues. I was able to corroborate the following:
I can import a custom starter
I can import and export bundles
I can push publish CT, Pages, files and other custom pieces of content. Therefore I am passing it

@fabrizzio-dotCMS fabrizzio-dotCMS moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Feb 2, 2024
@nollymar nollymar closed this as completed Feb 5, 2024
@github-project-automation github-project-automation bot moved this from QA - Backlog to Done in dotCMS - Product Planning Feb 5, 2024
@nollymar nollymar moved this from Done to QA - Backlog in dotCMS - Product Planning Feb 5, 2024
@josemejias11 josemejias11 moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Feb 5, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on master_a38321e, Docker, macOS 13.0, FF v121.0.1

@josemejias11 josemejias11 added QA : Approved Release : 24.02.20 New binary field, AI plugin labels Feb 6, 2024
@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OKR : Security & Privacy Owned by Mehdi Priority : 2 High QA : Approved QA : Passed Internal Release : 24.02.20 New binary field, AI plugin Team : Scout Type : Enhancement
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#21060 Create the XStreamFactory dotCMS/core
Upgrading xstream to version 1.4.20 dotCMS/core
9 participants
@wezell @dsilvam @nollymar @mbiuki @freddyucv @sfreudenthaler @fabrizzio-dotCMS @damen-dotcms @josemejias11