Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Unique per site to a field variable #22250

Closed
wezell opened this issue May 18, 2022 · 2 comments · Fixed by #22304
Closed

Move Unique per site to a field variable #22250

wezell opened this issue May 18, 2022 · 2 comments · Fixed by #22304
Labels
Doc : Needs Doc Merged QA : Approved QA : Passed Internal Release : 22.06 Team : Falcon Type : Defect

Comments

@wezell
Copy link
Contributor

wezell commented May 18, 2022 •
edited
Loading

In order to give more control over unique fields, we added a config property called uniquePerSite that controls whether fields marked unique are unique globally or per site.

We should have created a uniquePerSite field variable that controls, at the field level, whether the unique field is measured on a per site basis or a global basis. The default for this is false which would maintain the behavior of the unique field values in all dotCMS versions except 22.05, where the default was changed by accident.

We should revert the change to the default that was made in issue :
#21781
@freddyucv freddyucv self-assigned this May 26, 2022
freddyucv pushed a commit that referenced this issue May 26, 2022
@freddyDOTCMS
#22250 Moving unique oer site to field variable
7150426
dsilvam pushed a commit that referenced this issue Jun 1, 2022
@freddyDOTCMS @alfredo-dotcms
@fabrizzio-dotCMS @jdotcms @nollymar @wezell @fmontes
#22250 Moving unique per site to field variable (#22304)
b65ec66 
* #22131 fix show-or-hide-ViewStatistics-button-based-on-dotmarketing-property (#22201)

* #22073 adding test for AWSS3Publisher (#22200)

* #21060 Create the XStreamFactory (#22187)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* Add test in MainSuite

* Add test in MainSuite

* remove unnecessary change

* #21626 Container Resource (#21455)

* #2142 adding first draft

* #21432 optimizing the get link

* #21432 optimizing the get link2

* #21432 adding postman test

* #21432 adding template test

* #21432 first draft container

* adding unpublish

* #21432 unpublish container

* #21432 added save new container endpoint

* #21432 adding container bring back + curl test

* #21432 adding container bring back + curl test

* #21432 adding the methods for all containers operations

* #21432 adding first curl test for containers

* #21432 adding container publish/unpublish

* #21432 more container enhancements

* #21432 adding publish and unpublish for file container

* #21432 adding the archive functionality

* #21432 adding changes for retrieving archive file container

* #21432 adding the unarchive function

* #21432 added delete container

* #21432 clean up

* #21432 test and final changes to the container resource

* #21432 adding some fixes to the container curl test

* #21432 adding more curl test per feedback

* #21432 fixing curl test

* #21432 fixing curl test part 2

* #21432 finally fixed the curl test for containers

* #21432 fixing the curl test

* #21432 changes over the curl test

* #21432 adding a change to remove the container/test folder is exists and run the test from fresh

* #21432 adding more curl test

* #21432 adding PR feedback

* Targeting master as branch

* Validatee if exists a Vanity URL Contet Type with a site Custom field (#22232)

* #22186 The minSelections was modified to avoid refreshing screen without selecting a country (#22243)

Co-authored-by: nollymar <[email protected]>

* #22007 fixes rewrites when its a urlmap (#22142)

Co-authored-by: nollymar <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>

* Removing Task220404RemoveCalendarReminderTest

* #22250 Moving unique oer site to field variable

* #21060 Using XStreamFactory everywhere (#22192)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* #21060 Using XStreamFactory everywhere

* Just testing

* Testing

* Testing

* testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Fxing test

* Fixing test

* Removing ;

* refactoring

* Fixing test

* Revert "Fixing test"

This reverts commit 1541ff7.

* Revert "Revert "Fixing test""

This reverts commit 1bcee19.

* Revert "Merge remote-tracking branch 'origin/master' into issue-22250-Move-Unique-per-site-to-a-field-variable"

This reverts commit 82edb94, reversing
changes made to 1541ff7.

Co-authored-by: alfredo-dotcms <[email protected]>
Co-authored-by: Fabrizzio Araya <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: nollymar <[email protected]>
Co-authored-by: Nollymar Longa <[email protected]>
Co-authored-by: Will Ezell <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>
Co-authored-by: Freddy Montes <[email protected]>
@dsilvam dsilvam linked a pull request Jun 1, 2022 that will close this issue
#22250 Moving unique per site to field variable #22304
Merged
@dsilvam
Copy link
Contributor

dsilvam commented Jun 9, 2022

Passed Internal QA. Tested on docker using image 22.06_23437ee7_SNAPSHOT with full starter.

  1. Created new content type testType with fields title (text), and site (site or folder, unique)
  2. Created a new empty site copy
  3. Created content of new type testType with title "unico" on demo
  4. Tried to create a new content of type testType with same title on site copy. Failed as expected
  5. Set the field variable uniquePerSite to true on field title of type test.
  6. Tried step 4 again. Succeeded as expected

@bryanboza
Copy link
Contributor

Fixed, tested on release-22.06 // Docker // FF

oidacra pushed a commit that referenced this issue Jun 13, 2022
@freddyDOTCMS @alfredo-dotcms
@fabrizzio-dotCMS @jdotcms @nollymar @wezell @fmontes @oidacra
#22250 Moving unique per site to field variable (#22304)
7cc892d 
* #22131 fix show-or-hide-ViewStatistics-button-based-on-dotmarketing-property (#22201)

* #22073 adding test for AWSS3Publisher (#22200)

* #21060 Create the XStreamFactory (#22187)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* Add test in MainSuite

* Add test in MainSuite

* remove unnecessary change

* #21626 Container Resource (#21455)

* #2142 adding first draft

* #21432 optimizing the get link

* #21432 optimizing the get link2

* #21432 adding postman test

* #21432 adding template test

* #21432 first draft container

* adding unpublish

* #21432 unpublish container

* #21432 added save new container endpoint

* #21432 adding container bring back + curl test

* #21432 adding container bring back + curl test

* #21432 adding the methods for all containers operations

* #21432 adding first curl test for containers

* #21432 adding container publish/unpublish

* #21432 more container enhancements

* #21432 adding publish and unpublish for file container

* #21432 adding the archive functionality

* #21432 adding changes for retrieving archive file container

* #21432 adding the unarchive function

* #21432 added delete container

* #21432 clean up

* #21432 test and final changes to the container resource

* #21432 adding some fixes to the container curl test

* #21432 adding more curl test per feedback

* #21432 fixing curl test

* #21432 fixing curl test part 2

* #21432 finally fixed the curl test for containers

* #21432 fixing the curl test

* #21432 changes over the curl test

* #21432 adding a change to remove the container/test folder is exists and run the test from fresh

* #21432 adding more curl test

* #21432 adding PR feedback

* Targeting master as branch

* Validatee if exists a Vanity URL Contet Type with a site Custom field (#22232)

* #22186 The minSelections was modified to avoid refreshing screen without selecting a country (#22243)

Co-authored-by: nollymar <[email protected]>

* #22007 fixes rewrites when its a urlmap (#22142)

Co-authored-by: nollymar <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>

* Removing Task220404RemoveCalendarReminderTest

* #22250 Moving unique oer site to field variable

* #21060 Using XStreamFactory everywhere (#22192)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* #21060 Using XStreamFactory everywhere

* Just testing

* Testing

* Testing

* testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Fxing test

* Fixing test

* Removing ;

* refactoring

* Fixing test

* Revert "Fixing test"

This reverts commit 1541ff7.

* Revert "Revert "Fixing test""

This reverts commit 1bcee19.

* Revert "Merge remote-tracking branch 'origin/master' into issue-22250-Move-Unique-per-site-to-a-field-variable"

This reverts commit 82edb94, reversing
changes made to 1541ff7.

Co-authored-by: alfredo-dotcms <[email protected]>
Co-authored-by: Fabrizzio Araya <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: nollymar <[email protected]>
Co-authored-by: Nollymar Longa <[email protected]>
Co-authored-by: Will Ezell <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>
Co-authored-by: Freddy Montes <[email protected]>
@wezell wezell closed this as completed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Doc : Needs Doc Merged QA : Approved QA : Passed Internal Release : 22.06 Team : Falcon Type : Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#22250 Moving unique per site to field variable dotCMS/core
4 participants
@wezell @dsilvam @bryanboza @freddyucv