Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static Push Publishing fails to send one single File Asset #22073

Closed
fabrizzio-dotCMS opened this issue Apr 25, 2022 · 3 comments · Fixed by #22200
Closed

Static Push Publishing fails to send one single File Asset #22073

fabrizzio-dotCMS opened this issue Apr 25, 2022 · 3 comments · Fixed by #22200
Labels
Merged QA : Approved QA : Passed Internal Release : 22.08 Team : Scout Type : Defect

Comments

@fabrizzio-dotCMS
Copy link
Contributor

fabrizzio-dotCMS commented Apr 25, 2022 •
edited
Loading

Describe the bug
Found in Our Current Master - seems like it has been around for a while
When Sending one single File-Asse to an S3 Bucket the Generated bundle is Empty

To Reproduce
Steps to reproduce the behavior:

  1. Set up an s3 Bucket endpoint for push-publish
  2. Upload a fresh File Asset
  3. Push publish the File asset into the S3 endpoint. (Selecting the Force-Push Option)
  4. See on the logs a warning like:

Screen Shot 2022-04-25 at 10 06 46

This behavior is specific to Static Push. Regular Push publish is working as expected.

Expected behavior
We should be to force push an asset at any moment.

Additional context
I believe the error comes from this class AWSS3Publisher
Around line 141/142

The following condition is inverted and should probably set the result to true when the bucket is valid and not otherwise

if (!endPointPublisher.exists(bucketName)) {
      result = true;
     break outerLoop;
}
@fabrizzio-dotCMS fabrizzio-dotCMS self-assigned this May 10, 2022
fabrizzio-dotCMS added a commit that referenced this issue May 11, 2022
@fabrizzio-dotCMS
#22073 adding test for AWSS3Publisher
de817ee
@nollymar
Copy link
Contributor

PR EE: https://github.com/dotCMS/enterprise/pull/874
PR Core: #22200

@nollymar nollymar linked a pull request May 11, 2022 that will close this issue
#22073 adding test for AWSS3Publisher #22200
Merged
nollymar pushed a commit that referenced this issue May 12, 2022
@fabrizzio-dotCMS
#22073 adding test for AWSS3Publisher (#22200)
5fb6a30
@nollymar nollymar reopened this May 12, 2022
dsilvam pushed a commit that referenced this issue Jun 1, 2022
@freddyDOTCMS @alfredo-dotcms
@fabrizzio-dotCMS @jdotcms @nollymar @wezell @fmontes
#22250 Moving unique per site to field variable (#22304)
b65ec66 
* #22131 fix show-or-hide-ViewStatistics-button-based-on-dotmarketing-property (#22201)

* #22073 adding test for AWSS3Publisher (#22200)

* #21060 Create the XStreamFactory (#22187)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* Add test in MainSuite

* Add test in MainSuite

* remove unnecessary change

* #21626 Container Resource (#21455)

* #2142 adding first draft

* #21432 optimizing the get link

* #21432 optimizing the get link2

* #21432 adding postman test

* #21432 adding template test

* #21432 first draft container

* adding unpublish

* #21432 unpublish container

* #21432 added save new container endpoint

* #21432 adding container bring back + curl test

* #21432 adding container bring back + curl test

* #21432 adding the methods for all containers operations

* #21432 adding first curl test for containers

* #21432 adding container publish/unpublish

* #21432 more container enhancements

* #21432 adding publish and unpublish for file container

* #21432 adding the archive functionality

* #21432 adding changes for retrieving archive file container

* #21432 adding the unarchive function

* #21432 added delete container

* #21432 clean up

* #21432 test and final changes to the container resource

* #21432 adding some fixes to the container curl test

* #21432 adding more curl test per feedback

* #21432 fixing curl test

* #21432 fixing curl test part 2

* #21432 finally fixed the curl test for containers

* #21432 fixing the curl test

* #21432 changes over the curl test

* #21432 adding a change to remove the container/test folder is exists and run the test from fresh

* #21432 adding more curl test

* #21432 adding PR feedback

* Targeting master as branch

* Validatee if exists a Vanity URL Contet Type with a site Custom field (#22232)

* #22186 The minSelections was modified to avoid refreshing screen without selecting a country (#22243)

Co-authored-by: nollymar <[email protected]>

* #22007 fixes rewrites when its a urlmap (#22142)

Co-authored-by: nollymar <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>

* Removing Task220404RemoveCalendarReminderTest

* #22250 Moving unique oer site to field variable

* #21060 Using XStreamFactory everywhere (#22192)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* #21060 Using XStreamFactory everywhere

* Just testing

* Testing

* Testing

* testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Fxing test

* Fixing test

* Removing ;

* refactoring

* Fixing test

* Revert "Fixing test"

This reverts commit 1541ff7.

* Revert "Revert "Fixing test""

This reverts commit 1bcee19.

* Revert "Merge remote-tracking branch 'origin/master' into issue-22250-Move-Unique-per-site-to-a-field-variable"

This reverts commit 82edb94, reversing
changes made to 1541ff7.

Co-authored-by: alfredo-dotcms <[email protected]>
Co-authored-by: Fabrizzio Araya <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: nollymar <[email protected]>
Co-authored-by: Nollymar Longa <[email protected]>
Co-authored-by: Will Ezell <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>
Co-authored-by: Freddy Montes <[email protected]>
oidacra pushed a commit that referenced this issue Jun 13, 2022
@freddyDOTCMS @alfredo-dotcms
@fabrizzio-dotCMS @jdotcms @nollymar @wezell @fmontes @oidacra
#22250 Moving unique per site to field variable (#22304)
7cc892d 
* #22131 fix show-or-hide-ViewStatistics-button-based-on-dotmarketing-property (#22201)

* #22073 adding test for AWSS3Publisher (#22200)

* #21060 Create the XStreamFactory (#22187)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* Add test in MainSuite

* Add test in MainSuite

* remove unnecessary change

* #21626 Container Resource (#21455)

* #2142 adding first draft

* #21432 optimizing the get link

* #21432 optimizing the get link2

* #21432 adding postman test

* #21432 adding template test

* #21432 first draft container

* adding unpublish

* #21432 unpublish container

* #21432 added save new container endpoint

* #21432 adding container bring back + curl test

* #21432 adding container bring back + curl test

* #21432 adding the methods for all containers operations

* #21432 adding first curl test for containers

* #21432 adding container publish/unpublish

* #21432 more container enhancements

* #21432 adding publish and unpublish for file container

* #21432 adding the archive functionality

* #21432 adding changes for retrieving archive file container

* #21432 adding the unarchive function

* #21432 added delete container

* #21432 clean up

* #21432 test and final changes to the container resource

* #21432 adding some fixes to the container curl test

* #21432 adding more curl test per feedback

* #21432 fixing curl test

* #21432 fixing curl test part 2

* #21432 finally fixed the curl test for containers

* #21432 fixing the curl test

* #21432 changes over the curl test

* #21432 adding a change to remove the container/test folder is exists and run the test from fresh

* #21432 adding more curl test

* #21432 adding PR feedback

* Targeting master as branch

* Validatee if exists a Vanity URL Contet Type with a site Custom field (#22232)

* #22186 The minSelections was modified to avoid refreshing screen without selecting a country (#22243)

Co-authored-by: nollymar <[email protected]>

* #22007 fixes rewrites when its a urlmap (#22142)

Co-authored-by: nollymar <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>

* Removing Task220404RemoveCalendarReminderTest

* #22250 Moving unique oer site to field variable

* #21060 Using XStreamFactory everywhere (#22192)

* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* #21060 Using XStreamFactory everywhere

* Just testing

* Testing

* Testing

* testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Testing

* Fxing test

* Fixing test

* Removing ;

* refactoring

* Fixing test

* Revert "Fixing test"

This reverts commit 1541ff7.

* Revert "Revert "Fixing test""

This reverts commit 1bcee19.

* Revert "Merge remote-tracking branch 'origin/master' into issue-22250-Move-Unique-per-site-to-a-field-variable"

This reverts commit 82edb94, reversing
changes made to 1541ff7.

Co-authored-by: alfredo-dotcms <[email protected]>
Co-authored-by: Fabrizzio Araya <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: nollymar <[email protected]>
Co-authored-by: Nollymar Longa <[email protected]>
Co-authored-by: Will Ezell <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>
Co-authored-by: Freddy Montes <[email protected]>
@nollymar nollymar self-assigned this Jul 12, 2022
@nollymar
Copy link
Contributor

Internal QA: Passed

@nollymar nollymar removed their assignment Jul 14, 2022
@bryanboza
Copy link
Contributor

Fixed, tested release 22.07 and I'm able to push individual assets without problems.

@wezell wezell closed this as completed Aug 2, 2022
@erickgonzalez erickgonzalez removed the LTS: Needs Backport Ticket that will be added to LTS label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged QA : Approved QA : Passed Internal Release : 22.08 Team : Scout Type : Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#22073 adding test for AWSS3Publisher dotCMS/core
6 participants
@wezell @bryanboza @erickgonzalez @nollymar @fabrizzio-dotCMS @swicken-dotcms