Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22255: revert paths in copyDotCmsWebComponents #22256

Closed
wants to merge 12 commits into from

Conversation

spbolton
Copy link
Contributor

No description provided.

alfredo-dotcms and others added 11 commits May 11, 2022 18:19
* #21060 Create the XStreamFactory

* Add encoding

* Add Encoding

* Add test in MainSuite

* Add test in MainSuite

* remove unnecessary change
* #2142 adding first draft

* #21432 optimizing the get link

* #21432 optimizing the get link2

* #21432 adding postman test

* #21432 adding template test

* #21432 first draft container

* adding unpublish

* #21432 unpublish container

* #21432 added save new container endpoint

* #21432 adding container bring back + curl test

* #21432 adding container bring back + curl test

* #21432 adding the methods for all containers operations

* #21432 adding first curl test for containers

* #21432 adding container publish/unpublish

* #21432 more container enhancements

* #21432 adding publish and unpublish for file container

* #21432 adding the archive functionality

* #21432 adding changes for retrieving archive file container

* #21432 adding the unarchive function

* #21432 added delete container

* #21432 clean up

* #21432 test and final changes to the container resource

* #21432 adding some fixes to the container curl test

* #21432 adding more curl test per feedback

* #21432 fixing curl test

* #21432 fixing curl test part 2

* #21432 finally fixed the curl test for containers

* #21432 fixing the curl test

* #21432 changes over the curl test

* #21432 adding a change to remove the container/test folder is exists and run the test from fresh

* #21432 adding more curl test

* #21432 adding PR feedback
…-20220513

Merge release 22.06 into master 20220513
Co-authored-by: nollymar <[email protected]>
Co-authored-by: fabrizzio-dotCMS <[email protected]>
@spbolton spbolton requested a review from alfredo-dotcms May 19, 2022 00:24
@alfredo-dotcms
Copy link
Contributor

@spbolton after copying the files did you clean the extracted directory? so we don't have 2 directories with duplicated files

image

Copy link
Contributor

@nollymar nollymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spbolton this PR should target release-22.06

@spbolton
Copy link
Contributor Author

No to clean up server impacted by issue I guess we should, but hate to have a delete in here long term that is for one specific issue. Will add a delete of the bad folder if it exists and a comment to remove later.

@spbolton spbolton force-pushed the issue-22255-fix-webcomponents-copy branch 2 times, most recently from a042d57 to 3c765be Compare May 19, 2022 18:28
@spbolton spbolton changed the base branch from master to release-22.06 May 19, 2022 18:32
@spbolton
Copy link
Contributor Author

@spbolton this PR should target release-22.06

Ok, use this PR instead #22260

@spbolton spbolton closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants