Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][tests][aot] Test failure in System.Reflection.Tests #51673

Closed
radical opened this issue Apr 22, 2021 · 3 comments · Fixed by #53977
Closed

[wasm][tests][aot] Test failure in System.Reflection.Tests #51673

radical opened this issue Apr 22, 2021 · 3 comments · Fixed by #53977
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test
Milestone
6.0.0

Comments

@radical
Copy link
Member

radical commented Apr 22, 2021

Probably a build issue.

Log

/home/helixbot/work/B3DB0956/p/dotnet-cli/sdk/6.0.100-preview.2.21155.3/MSBuild.dll -maxcpucount -verbosity:m /bl:/home/helixbot/work/B3DB0956/w/B82A09B2/uploads/xharness-output/AOTBuild.binlog /p:RunAOTCompilation=true publish/AOTTestProjectForHelix.proj
  AOT'ing 54 assemblies
/home/helixbot/work/B3DB0956/p/build/wasm/WasmApp.targets(137,5): warning : Can not open image UnloadableAssembly.dll [/home/helixbot/work/B3DB0956/w/B82A09B2/e/publish/AOTTestProjectForHelix.proj]
/home/helixbot/work/B3DB0956/p/build/wasm/WasmApp.targets(137,5): error : Precompiling failed for /home/helixbot/work/B3DB0956/w/B82A09B2/e/wasm_build/../publish/UnloadableAssembly.dll: Error: Can not open image UnloadableAssembly.dll [/home/helixbot/work/B3DB0956/w/B82A09B2/e/publish/AOTTestProjectForHelix.proj]
/home/helixbot/work/B3DB0956/p/build/wasm/WasmApp.targets(137,5): error :  [/home/helixbot/work/B3DB0956/w/B82A09B2/e/publish/AOTTestProjectForHelix.proj]
/home/helixbot/work/B3DB0956/p/build/wasm/WasmApp.targets(137,5): error :  [/home/helixbot/work/B3DB0956/w/B82A09B2/e/publish/AOTTestProjectForHelix.proj]
XHarness artifacts: /home/helixbot/work/B3DB0956/w/B82A09B2/uploads/xharness-output
@radical radical added arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test labels Apr 22, 2021
@radical radical self-assigned this Apr 22, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 22, 2021
@ghost
Copy link

ghost commented Apr 22, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Probably a build issue.

Log

/home/helixbot/work/B3DB0956/p/dotnet-cli/sdk/6.0.100-preview.2.21155.3/MSBuild.dll -maxcpucount -verbosity:m /bl:/home/helixbot/work/B3DB0956/w/B82A09B2/uploads/xharness-output/AOTBuild.binlog /p:RunAOTCompilation=true publish/AOTTestProjectForHelix.proj
  AOT'ing 54 assemblies
/home/helixbot/work/B3DB0956/p/build/wasm/WasmApp.targets(137,5): warning : Can not open image UnloadableAssembly.dll [/home/helixbot/work/B3DB0956/w/B82A09B2/e/publish/AOTTestProjectForHelix.proj]
/home/helixbot/work/B3DB0956/p/build/wasm/WasmApp.targets(137,5): error : Precompiling failed for /home/helixbot/work/B3DB0956/w/B82A09B2/e/wasm_build/../publish/UnloadableAssembly.dll: Error: Can not open image UnloadableAssembly.dll [/home/helixbot/work/B3DB0956/w/B82A09B2/e/publish/AOTTestProjectForHelix.proj]
/home/helixbot/work/B3DB0956/p/build/wasm/WasmApp.targets(137,5): error :  [/home/helixbot/work/B3DB0956/w/B82A09B2/e/publish/AOTTestProjectForHelix.proj]
/home/helixbot/work/B3DB0956/p/build/wasm/WasmApp.targets(137,5): error :  [/home/helixbot/work/B3DB0956/w/B82A09B2/e/publish/AOTTestProjectForHelix.proj]
XHarness artifacts: /home/helixbot/work/B3DB0956/w/B82A09B2/uploads/xharness-output
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Codegen-AOT-mono, wasm-aot-test
Milestone: -

@radical radical changed the title [wasm][tests][aot] Error build System.Reflection.Tests [wasm][tests][aot] Error building System.Reflection.Tests Apr 22, 2021
@radical radical mentioned this issue Apr 28, 2021
Closed
@vargaz
Copy link
Contributor

vargaz commented May 6, 2021

Can't reproduce this, it builds with me, but there is one failure:

  fail: [FAIL] System.Reflection.Tests.AssemblyTests.GetCallingAssembly(assembly1: System.Reflection.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, assembly2: System.Reflection.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, expected: False)

This happens because Assembly.GetCallingAssembly () doesn't really work right now with AOT.

@radical radical removed their assignment May 6, 2021
@radical
Copy link
Member Author

radical commented May 6, 2021 

[10:41:01] fail: [FAIL] System.Reflection.Tests.AssemblyTests.GetCallingAssembly(assembly1: System.Reflection.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, assembly2: System.Reflection.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, expected: False)
[10:41:01] info: Assert.Equal() Failure
[10:41:01] info: Expected: False
[10:41:01] info: Actual:   True
[10:41:01] info:

@radical radical changed the title [wasm][tests][aot] Error building System.Reflection.Tests [wasm][tests][aot] Test failure in System.Reflection.Tests May 6, 2021
radical added a commit to radical/runtime that referenced this issue May 6, 2021
@radical
[wasm] System.Reflection.Tests - update to track change from crash to a
36cfc52 
.. test failure.
Issue: dotnet#51673
lewing pushed a commit that referenced this issue May 7, 2021
@radical
[wasm][aot] Update disabled tests to track new fixes on main (#52396)
d36313d 
* [wasm][aot] System.Runtime.Tests failing with a different issue now

The earlier one (#51960) was
fixed.
New: #52393

* Enable Common.Tests test tracked in #50955, already fixed on main

* [wasm] System.Reflection.Tests - update to track change from crash to a

.. test failure.
Issue: #51673

* Re-enable System.Collections.Tests, issue: #51037

* Disable Microsoft.Extensions.Logging.Generators, and System.IO.Pipelines

Issue: #52384
Issue: #50959

* Enable two System.Reflection.Metadata* tests

Issue: #51958

* Fix path for Microsoft.Extensions.Logging.Generators.Tests
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 7, 2021
@lewing lewing added this to the 6.0.0 milestone May 7, 2021
@radical radical mentioned this issue Jun 10, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 10, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[wasm][aot] Enable tests that are passing now radical/runtime
3 participants
@radical @lewing @vargaz