Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Extensions.Logging.Generators.Tests fails on wasm+aot #52384

Closed
vargaz opened this issue May 6, 2021 · 4 comments
Closed

Microsoft.Extensions.Logging.Generators.Tests fails on wasm+aot #52384

vargaz opened this issue May 6, 2021 · 4 comments
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono linkable-framework Issues associated with delivering a linker friendly framework wasm-aot-test WebAssembly AOT Test
Milestone
6.0.0

Comments

@vargaz
Copy link
Contributor

vargaz commented May 6, 2021

Building the test suite fails with an llvm assertion:

         cache:INFO:  - ok
         Basic Block in function 'Microsoft_CodeAnalysis_CSharp_Microsoft_CodeAnalysis_CSharp_SymbolDisplay_ToDisplayParts_Microsoft_CodeAnalysis_ISymbol_Microsoft_CodeAnalysis_SemanticModel_int_Microsoft_CodeAnalysis_SymbolDisplayFormat_bool' does not have terminator!
         label %482
         in function Microsoft_CodeAnalysis_CSharp_Microsoft_CodeAnalysis_CSharp_SymbolDisplay_ToDisplayParts_Microsoft_CodeAnalysis_ISymbol_Microsoft_CodeAnalysis_SemanticModel_int_Microsoft_CodeAnalysis_SymbolDisplayFormat_bool
     1>EXEC : LLVM error : Broken function found, compilation aborted! [/datadisks/disk1/work/BCA10A38/w/9AF2086D/e/publish/AOTTestProjectForHelix.proj]

This is caused by
dotnet/linker#2016
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels May 6, 2021
@vargaz vargaz added arch-wasm WebAssembly architecture wasm-aot-test WebAssembly AOT Test labels May 6, 2021
@ghost
Copy link

ghost commented May 6, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Building the test suite fails with an llvm assertion:

         cache:INFO:  - ok
         Basic Block in function 'Microsoft_CodeAnalysis_CSharp_Microsoft_CodeAnalysis_CSharp_SymbolDisplay_ToDisplayParts_Microsoft_CodeAnalysis_ISymbol_Microsoft_CodeAnalysis_SemanticModel_int_Microsoft_CodeAnalysis_SymbolDisplayFormat_bool' does not have terminator!
         label %482
         in function Microsoft_CodeAnalysis_CSharp_Microsoft_CodeAnalysis_CSharp_SymbolDisplay_ToDisplayParts_Microsoft_CodeAnalysis_ISymbol_Microsoft_CodeAnalysis_SemanticModel_int_Microsoft_CodeAnalysis_SymbolDisplayFormat_bool
     1>EXEC : LLVM error : Broken function found, compilation aborted! [/datadisks/disk1/work/BCA10A38/w/9AF2086D/e/publish/AOTTestProjectForHelix.proj]

This is caused by
dotnet/linker#2016

Author: vargaz
Assignees: -
Labels:

arch-wasm, area-CodeGen-coreclr, untriaged, wasm-aot-test
Milestone: -

radical added a commit to radical/runtime that referenced this issue May 6, 2021
@radical
Disable Microsoft.Extensions.Logging.Generators, and System.IO.Pipelines
6d81589 
Issue: dotnet#52384
Issue: dotnet#50959
@lewing lewing mentioned this issue May 6, 2021
Merged
lewing pushed a commit that referenced this issue May 7, 2021
@radical
[wasm][aot] Update disabled tests to track new fixes on main (#52396)
d36313d 
* [wasm][aot] System.Runtime.Tests failing with a different issue now

The earlier one (#51960) was
fixed.
New: #52393

* Enable Common.Tests test tracked in #50955, already fixed on main

* [wasm] System.Reflection.Tests - update to track change from crash to a

.. test failure.
Issue: #51673

* Re-enable System.Collections.Tests, issue: #51037

* Disable Microsoft.Extensions.Logging.Generators, and System.IO.Pipelines

Issue: #52384
Issue: #50959

* Enable two System.Reflection.Metadata* tests

Issue: #51958

* Fix path for Microsoft.Extensions.Logging.Generators.Tests
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 7, 2021
@lewing lewing added this to the 6.0.0 milestone May 7, 2021
@AndyAyersMS
Copy link
Member

AndyAyersMS commented May 7, 2021 •
edited
Loading

@vargaz guessing you wanted a different codegen area here?

@lewing lewing added the linkable-framework Issues associated with delivering a linker friendly framework label May 7, 2021
@ghost
Copy link

ghost commented May 7, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

Building the test suite fails with an llvm assertion:

         cache:INFO:  - ok
         Basic Block in function 'Microsoft_CodeAnalysis_CSharp_Microsoft_CodeAnalysis_CSharp_SymbolDisplay_ToDisplayParts_Microsoft_CodeAnalysis_ISymbol_Microsoft_CodeAnalysis_SemanticModel_int_Microsoft_CodeAnalysis_SymbolDisplayFormat_bool' does not have terminator!
         label %482
         in function Microsoft_CodeAnalysis_CSharp_Microsoft_CodeAnalysis_CSharp_SymbolDisplay_ToDisplayParts_Microsoft_CodeAnalysis_ISymbol_Microsoft_CodeAnalysis_SemanticModel_int_Microsoft_CodeAnalysis_SymbolDisplayFormat_bool
     1>EXEC : LLVM error : Broken function found, compilation aborted! [/datadisks/disk1/work/BCA10A38/w/9AF2086D/e/publish/AOTTestProjectForHelix.proj]

This is caused by
dotnet/linker#2016

Author: vargaz
Assignees: -
Labels:

arch-wasm, area-CodeGen-coreclr, linkable-framework, wasm-aot-test
Milestone: 6.0.0

@lewing lewing added area-Codegen-AOT-mono and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels May 7, 2021
@eerhardt
Copy link
Member

dotnet/linker#2016 is now closed. Can this issue be closed?

lewing added a commit to lewing/runtime that referenced this issue May 18, 2021
@lewing
Remove exclusion for dotnet#52384
fbd3227
@lewing lewing closed this as completed May 18, 2021
marek-safar pushed a commit that referenced this issue May 19, 2021
@lewing
Remove exclusion for #52384 (#52950)
9ac15f7
@ghost ghost locked as resolved and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono linkable-framework Issues associated with delivering a linker friendly framework wasm-aot-test WebAssembly AOT Test
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
4 participants
@lewing @vargaz @eerhardt @AndyAyersMS