Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][aot] sig->call_convention != MONO_CALL_VARARG assertion forSystem.Runtime.Tests.dll #51960

Closed
radical opened this issue Apr 27, 2021 · 4 comments · Fixed by #52369
Closed

[wasm][aot] sig->call_convention != MONO_CALL_VARARG assertion forSystem.Runtime.Tests.dll #51960

radical opened this issue Apr 27, 2021 · 4 comments · Fixed by #52369
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono disabled-test The test is disabled in source code against the issue untriaged New issue has not been triaged by the area owner wasm-aot-test WebAssembly AOT Test

Comments

@radical
Copy link
Member

radical commented Apr 27, 2021

System.Runtime.Tests

/home/helixbot/work/AA8B0906/p/dotnet-cli/sdk/6.0.100-preview.2.21155.3/MSBuild.dll -maxcpucount -verbosity:m /bl:/home/helixbot/work/AA8B0906/w/A5D60920/uploads/xharness-output/AOTBuild.binlog /p:RunAOTCompilation=true publish/AOTTestProjectForHelix.proj
  AOT'ing 66 assemblies
/home/helixbot/work/AA8B0906/p/build/wasm/WasmApp.targets(140,5): error : Precompiling failed for /home/helixbot/work/AA8B0906/w/A5D60920/e/wasm_build/../publish/System.Runtime.Tests.dll: Error:  [/home/helixbot/work/AA8B0906/w/A5D60920/e/publish/AOTTestProjectForHelix.proj]
/home/helixbot/work/AA8B0906/p/build/wasm/WasmApp.targets(140,5): error :  [/home/helixbot/work/AA8B0906/w/A5D60920/e/publish/AOTTestProjectForHelix.proj]
XHarness artifacts: /home/helixbot/work/AA8B0906/w/A5D60920/uploads/xharness-output
@radical radical added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test labels Apr 27, 2021
@ghost
Copy link

ghost commented Apr 27, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Runtime.Tests

/home/helixbot/work/AA8B0906/p/dotnet-cli/sdk/6.0.100-preview.2.21155.3/MSBuild.dll -maxcpucount -verbosity:m /bl:/home/helixbot/work/AA8B0906/w/A5D60920/uploads/xharness-output/AOTBuild.binlog /p:RunAOTCompilation=true publish/AOTTestProjectForHelix.proj
  AOT'ing 66 assemblies
/home/helixbot/work/AA8B0906/p/build/wasm/WasmApp.targets(140,5): error : Precompiling failed for /home/helixbot/work/AA8B0906/w/A5D60920/e/wasm_build/../publish/System.Runtime.Tests.dll: Error:  [/home/helixbot/work/AA8B0906/w/A5D60920/e/publish/AOTTestProjectForHelix.proj]
/home/helixbot/work/AA8B0906/p/build/wasm/WasmApp.targets(140,5): error :  [/home/helixbot/work/AA8B0906/w/A5D60920/e/publish/AOTTestProjectForHelix.proj]
XHarness artifacts: /home/helixbot/work/AA8B0906/w/A5D60920/uploads/xharness-output
Author: radical
Assignees: -
Labels:

arch-wasm, area-Codegen-AOT-mono, disabled-test, wasm-aot-test
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 27, 2021
@radical
Copy link
Member Author

radical commented Apr 27, 2021

The binlog should have details on why this failed.

@radical
Copy link
Member Author

radical commented Apr 27, 2021

From the binlog:

[AOT] /home/helixbot/work/AA8B0906/w/A5D60920/e/wasm_build/../publish/System.Runtime.Tests.dll (TaskId:4)
Running: /home/helixbot/work/AA8B0906/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/native/cross/browser-wasm/mono-aot-cross --debug --llvm "--aot=no-opt,static,direct-icalls,deterministic,dwarfdebug,llvm-path=/home/helixbot/work/AA8B0906/p/build/emsdk/upstream/bin/,llvmonly,interp,asmonly,llvm-outfile=/home/helixbot/work/AA8B0906/w/A5D60920/e/wasm_build/obj/wasm/System.Runtime.Tests.dll.bc" System.Runtime.Tests.dll (TaskId:4)
Using working directory: /home/helixbot/work/AA8B0906/w/A5D60920/e/wasm_build/../publish (TaskId:4)
Setting environment variables for execution: (TaskId:4)
   MONO_PATH = /home/helixbot/work/AA8B0906/w/A5D60920/e/wasm_build/../publish:/home/helixbot/work/AA8B0906/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/native/:/home/helixbot/work/AA8B0906/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/lib/net6.0 (TaskId:4)
   MONO_ENV_OPTIONS =  (TaskId:4)
Mono Ahead of Time compiler - compiling assembly /home/helixbot/work/AA8B0906/w/A5D60920/e/publish/System.Runtime.Tests.dll (TaskId:4)
* Assertion at /__w/1/s/src/mono/mono/mini/mini-wasm.c:117, condition `sig->call_convention != MONO_CALL_VARARG' not met (TaskId:4)
 (TaskId:4)
Exit code: 134 (TaskId:4)
System.Exception: Error:

   at Utils.RunProcess(String path, String args, IDictionary`2 envVars, String workingDir, Boolean ignoreErrors, Boolean silent, MessageImportance outputMessageImportance, MessageImportance debugMessageImportance) in /_/src/tasks/Common/Utils.cs:line 99
   at MonoAOTCompiler.PrecompileLibrary(ITaskItem assemblyItem, String monoPaths) in /_/src/tasks/AotCompilerTask/MonoAOTCompiler.cs:line 413 (TaskId:4)
1>/home/helixbot/work/AA8B0906/p/build/wasm/WasmApp.targets(140,5): error : Precompiling failed for /home/helixbot/work/AA8B0906/w/A5D60920/e/wasm_build/../publish/System.Runtime.Tests.dll: Error:  [/home/helixbot/work/AA8B0906/w/A5D60920/e/publish/AOTTestProjectForHelix.proj]

@radical radical changed the title [wasm][aot] Precompiling failed forSystem.Runtime.Tests.dll [wasm][aot] condition sig->call_convention != MONO_CALL_VARARG' assertion forSystem.Runtime.Tests.dll` Apr 27, 2021
@marek-safar
Copy link
Contributor

@vargaz is this something we should declare as unsupported on wasm?

@radical radical changed the title [wasm][aot] condition sig->call_convention != MONO_CALL_VARARG' assertion forSystem.Runtime.Tests.dll` [wasm][aot] sig->call_convention != MONO_CALL_VARARG assertion forSystem.Runtime.Tests.dll Apr 28, 2021
vargaz added a commit to vargaz/runtime that referenced this issue May 6, 2021
@vargaz
[mono][aot] Avoid an assert on wasm+aot on methods with vararg callin…
ed8d5f3 
…g conventions.

Fixes dotnet#51960.
@vargaz vargaz mentioned this issue May 6, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 6, 2021
vargaz added a commit that referenced this issue May 6, 2021
@vargaz
[mono][aot] Avoid an assert on wasm+aot on methods with vararg callin…
cff26f4 
…g conventions. (#52369)

Fixes #51960.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 6, 2021
@radical radical mentioned this issue May 6, 2021
Merged
radical added a commit to radical/runtime that referenced this issue May 6, 2021
@radical
[wasm][aot] System.Runtime.Tests failing with a different issue now
de99a3e 
The earlier one (dotnet#51960) was
fixed.
New: dotnet#52393
lewing pushed a commit that referenced this issue May 7, 2021
@radical
[wasm][aot] Update disabled tests to track new fixes on main (#52396)
d36313d 
* [wasm][aot] System.Runtime.Tests failing with a different issue now

The earlier one (#51960) was
fixed.
New: #52393

* Enable Common.Tests test tracked in #50955, already fixed on main

* [wasm] System.Reflection.Tests - update to track change from crash to a

.. test failure.
Issue: #51673

* Re-enable System.Collections.Tests, issue: #51037

* Disable Microsoft.Extensions.Logging.Generators, and System.IO.Pipelines

Issue: #52384
Issue: #50959

* Enable two System.Reflection.Metadata* tests

Issue: #51958

* Fix path for Microsoft.Extensions.Logging.Generators.Tests
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono disabled-test The test is disabled in source code against the issue untriaged New issue has not been triaged by the area owner wasm-aot-test WebAssembly AOT Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mono][aot] Avoid an assert on wasm+aot on methods with vararg callin… vargaz/runtime
2 participants
@radical @marek-safar