Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19.0.0 release #2541

Merged
merged 24 commits into from
Jan 29, 2025
Merged

19.0.0 release #2541

merged 24 commits into from
Jan 29, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 27, 2025

Merge to master for release

Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 85711c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ArtBlue
ArtBlue previously approved these changes Jan 28, 2025
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

HenriqueLimas
HenriqueLimas previously approved these changes Jan 28, 2025
@ianmcburnie
Copy link
Contributor

ianmcburnie commented Jan 28, 2025

It looks like both of the page grid examples are broken (they are also all broken in the skeleton examples)

Screenshot 2025-01-28 at 10 15 53 AM Screenshot 2025-01-28 at 10 15 47 AM

HenriqueLimas
HenriqueLimas previously approved these changes Jan 29, 2025
ArtBlue
ArtBlue previously approved these changes Jan 29, 2025
@ArtBlue ArtBlue dismissed stale reviews from HenriqueLimas and themself via 85711c5 January 29, 2025 22:13
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
@agliga agliga merged commit a19d10e into master Jan 29, 2025
3 checks passed
@agliga agliga deleted the 19.0.0 branch January 29, 2025 22:16
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants