Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up references to old opcodes #7529

Merged

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Nov 6, 2024

The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead.

This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code.

Depends on

Related: eclipse-openj9/openj9#19489

The old opcodes had the letter i as a prefix if the operation
was indirect. Those opcodes were renamed to use the letter i
as a suffix instead.

This commit cleans up the references to the old opcodes,
iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore,
to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei
in the code.

Related: eclipse-openj9/openj9#19489
Signed-off-by: Annabelle Huo <[email protected]>
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Nov 6, 2024

@hzongaro May I ask you to review this change? Thank you!

Please note that this PR depends on OpenJ9 PR eclipse-openj9/openj9#20521 and they should be reviewed together. And it will require coordinated merge with the OpenJ9 PR.

Copy link
Contributor

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Contributor

hzongaro commented Nov 7, 2024

Jenkins build all

@hzongaro
Copy link
Contributor

It doesn't look like the testing ran. Trying again. . . .

Jenkins build all

@AdamBrousseau
Copy link
Contributor

jenkins build zlinux

1 similar comment
@AdamBrousseau
Copy link
Contributor

jenkins build zlinux

@hzongaro hzongaro merged commit 3da49aa into eclipse-omr:master Nov 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants