Clean up references to old opcodes #20521
Merged
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead. This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code. Related: eclipse-openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
1 task
a7ehuo
added
comp:jit
depends:omr
|
@hzongaro May I ask you to review this change? Thank you! Please note that this PR depends on OMR PR eclipse-omr/omr#7529 and they should be reviewed together. And it will require coordinated merge with the OMR PR. |
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jd21 |
Meanwhile, this PR depends on eclipse-omr/omr#7529 |
Sigh! Yes and yes. Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7529 |
|
JDK 8 sanity.openjdk failures look like they should be fixed by pull request ibmruntimes/openj9-openjdk-jdk8#780. Rerunning those tests. Jenkins test sanity.openjdk all jdk8 depends eclipse-omr/omr#7529 |
|
Here are the failed 8 tests. So far I'm not sure of (1) Test_openjdk11_j9_sanity.openjdk_ppc64le_linux_Personal: Known issue #17515 (comment) (2) Test_openjdk17_j9_sanity.openjdk_s390x_linux_Personal: Not sure at the moment (3) Test_openjdk21_j9_sanity.openjdk_ppc64_aix_Personal: Not sure at the moment (4) Test_openjdk21_j9_sanity.openjdk_x86-64_mac_Personal: Known issue #19249 (comment) (5) Test_openjdk8_j9_sanity.functional_aarch64_linux_Personal: Known issue #20531 (comment) (6) Test_openjdk8_j9_sanity.functional_ppc64le_linux_Personal: Known issue #20531 (comment) (7) Test_openjdk8_j9_sanity.functional_s390x_linux_Personal: Known issue #20531 (comment) (8) Test_openjdk8_j9_sanity.functional_x86-64_linux_Personal: Known issue #20531 (comment) |
|
About (3) Test_openjdk21_j9_sanity.openjdk_ppc64_aix_Personal: I think the failure is similar to #19962 (comment). This time it also fails with the same sub tests on same platform ppc64_aix |
|
Thanks, @a7ehuo, for investigating those failures. I think the JDK 8 sanity.functional problems have been resolved, so I will rerun them. The JDK 17 sanity.openjdk failure on zLinux doesn't look like it would be related to this change. I will try rerunning it as well, and if it succeeds, I will assume it was unrelated. Jenkins test sanity.functional alinux,plinux,xlinux,zlinux jdk8 depends eclipse-omr/omr#7529 |
|
Jenkins test sanity.openjdk zlinux jdk17 depends eclipse-omr/omr#7529 |
|
About (2) Test_openjdk17_j9_sanity.openjdk_s390x_linux_Personal, I also ran |
|
I think this change and eclipse-omr/omr#7529 can be merged. Failures are for known reasons or extremely unlikely to have been caused by these changes. I will have to wait for the next OMR acceptance build before I can proceed with the coordinated merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead.
This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code.
Depends on
Related: #19489