Clean up references to iiload, iistore, et al. #19489
Assignees
Labels
Comments
|
I will start cleaning up the comments in OMR first |
a7ehuo
added a commit
to a7ehuo/omr
that referenced
this issue
Nov 1, 2024
…bload/ibstore This commit cleans up the references in the code comments Related: eclipse-openj9/openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
added a commit
to a7ehuo/omr
that referenced
this issue
Nov 4, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead. This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code comments and trace messages. Related: eclipse-openj9/openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
|
My plan is
|
a7ehuo
added a commit
to a7ehuo/openj9
that referenced
this issue
Nov 4, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter as a suffix instead. This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code comments and trace messages Related: eclipse-openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
added a commit
to a7ehuo/omr
that referenced
this issue
Nov 6, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead. This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code. Related: eclipse-openj9/openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
added a commit
to a7ehuo/openj9
that referenced
this issue
Nov 6, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead. This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code. Related: eclipse-openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
This was referenced Nov 6, 2024
zl-wang
pushed a commit
to zl-wang/openj9
that referenced
this issue
Nov 11, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter as a suffix instead. This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code comments and trace messages Related: eclipse-openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
added a commit
to a7ehuo/omr
that referenced
this issue
Nov 13, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead. This commit cleans up the references to the old opcodes, isload/isstore ifload/ifstore idload/idstore to sloadi/sstorei floadi/fstorei dloadi/dstorei Related: eclipse-openj9/openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
added a commit
to a7ehuo/openj9
that referenced
this issue
Nov 13, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead. This commit cleans up the references to the old opcodes, isload/isstore ifload/ifstore idload/idstore to sloadi/sstorei floadi/fstorei dloadi/dstorei Related: eclipse-openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
This was referenced Nov 13, 2024
a7ehuo
added a commit
to a7ehuo/openj9
that referenced
this issue
Nov 13, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead. This commit cleans up the references to the old opcodes, from isload/isstore to sloadi/sstorei Related: eclipse-openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
|
All five steps of cleaning up the old opcodes have been completed. Hence close |
|
Issue Number: 19489 |
theresa-m
pushed a commit
to theresa-m/openj9
that referenced
this issue
Nov 15, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter i as a suffix instead. This commit cleans up the references to the old opcodes, from isload/isstore to sloadi/sstorei Related: eclipse-openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
ThanHenderson
pushed a commit
to ThanHenderson/openj9
that referenced
this issue
Nov 25, 2024
The old opcodes had the letter i as a prefix if the operation was indirect. Those opcodes were renamed to use the letter as a suffix instead. This commit cleans up the references to the old opcodes, iiload/iistore ilload/ilstore iaload/iastore ibload/ibstore, to iloadi/istorei lloadi/lstorei aloadi/astorei bloadi/bstorei in the code comments and trace messages Related: eclipse-openj9#19489 Signed-off-by: Annabelle Huo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once upon a time, the JIT compiler's opcodes had the letter i as a prefix if the operation was indirect —
iiload,ibstore, and so on. Those opcodes were renamed to use the letter i as a suffix instead —iiloadbecameiloadi,ilstorebecameistorei, etc.Many comments and some trace code in the compiler — in both OpenJ9 and OMR — still refer to the old opcode names. For example, in Tree Simplifier and Inliner. It would be good to correct those lingering references to the old opcode names.
The text was updated successfully, but these errors were encountered: