-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable testing for binding-firestore and binding-mbus #865
chore: disable testing for binding-firestore and binding-mbus #865
Conversation
I think it is not the test, but firestore dependencies. You have to exclude the package in the workspaces: https://github.com/eclipse/thingweb.node-wot/blob/master/package.json#L37 |
I hoped excluding the tests is sufficient but apparently it is not... |
Now mbus is causing issues ?
|
seems that both packages are using old native libraries that are causing problems? |
The funny part is that re-running the tests often helps.. this means to me at least it is somewhat temporal !? |
I excluded firebase also from the building process |
Mhh, seems not enough. I disabled/excluded mbus also to see whether that helps... |
There are some people to complain about node-gyp and windows-latest. Maybe this can help... but I would defer it since I don't have the bandwidth to try that fix. |
it is failing again.... maybe it is the Modbus binding. It depends on serialport too. 😢 |
I think that command only work for windows... |
Shall we use |
It would be better to use windows latest but I'm okay with it for focusing on other features. |
I guess we have to reopen this one: #678 |
this chain of failures starts to be creepy 👻 😆 . |
Yes, very strange... since now mac-os-latest fails with gyp problems also !? |
let's try |
It seems that all the latest runners have some sort of problem with node-gyp... |
Mhh, I also hope the issues get solved on their own and hence I suggest to use
|
Yes I think this should be the priority now... let's fix what we can and have an issue to keep track of this problem |
For now I see 2 ways forward. Go with this PR and exclude some bindings like firestore/mbus plus settle to older OS runners. An alternative can be seen in #878. By default we could run CI with What do people think? |
Closed in favor of #878 |
see issues described in #827