Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable testing for binding-firestore and binding-mbus #865

Conversation

danielpeintner
Copy link
Member

see issues described in #827

@relu91
Copy link
Member

relu91 commented Nov 8, 2022

I think it is not the test, but firestore dependencies. You have to exclude the package in the workspaces: https://github.com/eclipse/thingweb.node-wot/blob/master/package.json#L37

@danielpeintner
Copy link
Member Author

I hoped excluding the tests is sufficient but apparently it is not...

@danielpeintner
Copy link
Member Author

Now mbus is causing issues ?

npm ERR! path /Users/runner/work/thingweb.node-wot/thingweb.node-wot/node_modules/node-mbus
see https://github.com/eclipse/thingweb.node-wot/actions/runs/3420221062/jobs/5694753037#step:5:7

@relu91
Copy link
Member

relu91 commented Nov 8, 2022

seems that both packages are using old native libraries that are causing problems?

@danielpeintner
Copy link
Member Author

The funny part is that re-running the tests often helps.. this means to me at least it is somewhat temporal !?

@relu91
Copy link
Member

relu91 commented Nov 9, 2022

I excluded firebase also from the building process

@danielpeintner
Copy link
Member Author

Mhh, seems not enough. I disabled/excluded mbus also to see whether that helps...

@relu91
Copy link
Member

relu91 commented Nov 9, 2022

Mhh, seems not enough. I disabled/excluded mbus also to see whether that helps...

There are some people to complain about node-gyp and windows-latest. Maybe this can help... but I would defer it since I don't have the bandwidth to try that fix.

@relu91
Copy link
Member

relu91 commented Nov 9, 2022

it is failing again.... maybe it is the Modbus binding. It depends on serialport too. 😢

@relu91
Copy link
Member

relu91 commented Nov 9, 2022

I think that command only work for windows...

@danielpeintner
Copy link
Member Author

Shall we use windows-2019 instead of windows-latest

@relu91
Copy link
Member

relu91 commented Nov 9, 2022

Shall we use windows-2019 instead of windows-latest

It would be better to use windows latest but I'm okay with it for focusing on other features.

@relu91
Copy link
Member

relu91 commented Nov 9, 2022

I guess we have to reopen this one: #678

@relu91
Copy link
Member

relu91 commented Nov 9, 2022

this chain of failures starts to be creepy 👻 😆 .

@danielpeintner
Copy link
Member Author

danielpeintner commented Nov 9, 2022

Yes, very strange... since now mac-os-latest fails with gyp problems also !?
see https://github.com/eclipse/thingweb.node-wot/actions/runs/3428354503/jobs/5712521235

@danielpeintner
Copy link
Member Author

danielpeintner commented Nov 11, 2022

let's try macos-12 macos-10.15 instead of macos-latest (maybe it helps to use a different runner).
Anyhow, VERY VERY strange !?

@relu91
Copy link
Member

relu91 commented Nov 11, 2022

It seems that all the latest runners have some sort of problem with node-gyp... macos-10.15 is depecrated accordingly to the documentation. What is weird is that I got the same problem with a node alpine docker image today. Maybe it is something broken in the latest npm 8.x.y version? 🤔 .

@danielpeintner
Copy link
Member Author

danielpeintner commented Nov 14, 2022

Mhh, I also hope the issues get solved on their own and hence I suggest to use non-latest runners do catch actual issues and open a new issue to track this problem? What do people think?

Note: I will try to bring mbus (and firestore) back to see whether the issues are gone also..
I tried to bring mbus back and it fails again even with the older runners.
Shall we exclude mbus & firestore for now and use the older runners to get at least clean runs for all the PRs?

@danielpeintner danielpeintner changed the title chore: disable testing for binding-firestore chore: disable testing for binding-firestore and binding-mbus Nov 22, 2022
@relu91
Copy link
Member

relu91 commented Nov 23, 2022

Shall we exclude mbus & firestore for now and use the older runners to get at least clean runs for all the PRs?

Yes I think this should be the priority now... let's fix what we can and have an issue to keep track of this problem

@danielpeintner
Copy link
Member Author

For now I see 2 ways forward. Go with this PR and exclude some bindings like firestore/mbus plus settle to older OS runners.

An alternative can be seen in #878. By default we could run CI with ubuntu_latest only (for now at least). We can still trigger to run the full test manually. Besides resolving CI issues the build process is much faster since we just need to run in on one OS.

What do people think?
@relu91 @egekorkan @JKRhb others ?

@danielpeintner
Copy link
Member Author

Closed in favor of #878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants