Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kafka] [TSDB] Added dimension field mapping for consumergroup datastream #5959

Closed

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Apr 21, 2023

Type of change

  • Enhancement

What does this PR do?

Added metric_type mapping for broker datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@agithomas agithomas requested a review from a team as a code owner April 21, 2023 14:54
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-21T14:55:08.102+0000

  • Duration: 15 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 72.222% (13/18)
Lines 77.778% (56/72)
Conditionals 100.0% (0/0) 💚

bhapas and others added 12 commits April 22, 2023 00:49
* [aws]Fix json input for pipeline tests

* [ceph]fix input for pipeline tests

* [citrix_adc]Fix ijson input for pipeline tests

* [okta]Fix json input for pipeline tests

* [citrix_adc]fix pipeline to have double type instead of float
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.7.0...v0.8.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
add top level link to Docs Guidelines docs.
Previously the url fields were being populated by the referrer URL parts
in the http_request datastream and the request fields were incompletely
filled in the firewall_events datastream.

The use of the uri_parts processor to populate the url fields is a little
troubling in the http_request datastream as the field used, ClientRequestURI,
is not a URL and is arguably not even a URI without the context of the
other ClientRequest* fields.
* Initial release for the Bitwarden

* Update the changelog entry

* Remove members data stream and resolve review comments.

* resolve review comments by adding bound check condition

* update event kind to event for policy, group and collection data-stream
…c#5940)

Bumps [github.com/elastic/elastic-package](https://github.com/elastic/elastic-package) from 0.77.0 to 0.78.0.
- [Release notes](https://github.com/elastic/elastic-package/releases)
- [Changelog](https://github.com/elastic/elastic-package/blob/main/.goreleaser.yml)
- [Commits](elastic/elastic-package@v0.77.0...v0.78.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-package
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@agithomas agithomas force-pushed the issue-5905-kafka-tsdb-dim-consumergroup branch from 050cd0e to 07aeb54 Compare April 22, 2023 00:51
@agithomas agithomas requested review from a team as code owners April 22, 2023 00:51
@agithomas agithomas requested review from AndersonQ and pchila April 22, 2023 00:51
@agithomas agithomas closed this Apr 22, 2023
@agithomas agithomas deleted the issue-5905-kafka-tsdb-dim-consumergroup branch April 22, 2023 00:52
@agithomas
Copy link
Contributor Author

Closing the PR because of Rebase issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants