Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for the dark theme #6767

Merged
merged 4 commits into from
Apr 7, 2016
Merged

Fixes for the dark theme #6767

merged 4 commits into from
Apr 7, 2016

Conversation

panda01
Copy link
Contributor

@panda01 panda01 commented Apr 4, 2016

Closes #6602.

@panda01
[DarkTheme] Added back the options dropdown for toggling dark theme, …
3bd1758 
…also made fixes to less to fix dark theme issues
@panda01 panda01 self-assigned this Apr 4, 2016
@panda01 panda01 added v5.0.0 bug Fixes for quality problems that affect the customer experience labels Apr 4, 2016
@panda01 panda01 assigned rashidkpc and unassigned panda01 Apr 4, 2016
@panda01 panda01 added the review label Apr 4, 2016
@rashidkpc
Copy link
Contributor

screen shot 2016-04-05 at 9 36 22 am

  • Button/placeholder alignment
  • Tab should join with body
  • Button isn't readable

@rashidkpc
Copy link
Contributor

screen shot 2016-04-05 at 9 37 45 am

  • Rows should have alternating colors
  • Border around tabs is not consistent with the style of the rest of the application. Get rid of the border, use a different color for the body of the drop down and the tab content.

@rashidkpc
Copy link
Contributor

screen shot 2016-04-05 at 9 45 41 am

  • Get rid of the bordered look on the panels,
  • See the color on the title bar? Use the same color for the body of the panel, and for the dashboard background.
  • Darken the buttons in the legend.

@rashidkpc rashidkpc assigned panda01 and unassigned rashidkpc Apr 5, 2016
@panda01
Copy link
Contributor Author

panda01 commented Apr 5, 2016

@rashidkpc Hmm, I always thought it was just dashboard that had the dark theme. Perhaps i don't quite get what you mean.

@rashidkpc
Copy link
Contributor

Ignore me, I'm being dumb, except on the comments with a screenshot :-) Stupid comment of stupidness deleted

@panda01
Copy link
Contributor Author

panda01 commented Apr 5, 2016

Hmm, well I thought of something similar, so, #6786.

@panda01
Copy link
Contributor Author

panda01 commented Apr 6, 2016

@rashidkpc addressed your concerns.

@panda01 panda01 assigned rashidkpc and unassigned panda01 Apr 6, 2016
@rashidkpc
Copy link
Contributor

@panda01 this largely looks good, although when you click one of the nav buttons they flash white on press. Fix that and go ahead and merge this

@rashidkpc rashidkpc assigned panda01 and unassigned rashidkpc Apr 7, 2016
@panda01
Copy link
Contributor Author

panda01 commented Apr 7, 2016

Gotcha. Just fixed that, just want this build to pass even though it's CSS.

@rashidkpc rashidkpc merged commit 4e9e2ca into elastic:master Apr 7, 2016
@rashidkpc rashidkpc mentioned this pull request Apr 13, 2016
Closed
@prashanttct07
Copy link

prashanttct07 commented Apr 25, 2016 •
edited
Loading

I am not able to switch dark/light theme in 5.0 alpha for the saved dashboard?

@panda01
Copy link
Contributor Author

panda01 commented Apr 25, 2016

I removed it accidentally, it's not in current 5.0
On Apr 25, 2016 06:20, "Prashant Agrawal" [email protected] wrote:

I am not able to find dark theme option in 5.0 alpha , where can I get
that option for Dashboard?

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#6767 (comment)

@prashanttct07
Copy link

Oh oki , I think I already opened an issue for that so if no issue is opened already for that you can refer #7042

@rashidkpc rashidkpc mentioned this pull request Apr 25, 2016
Closed
tkajtoch added a commit that referenced this pull request May 18, 2023
@tkajtoch @kibanamachine
Upgrade EUI to v80.0.0 (#157939)
b754a2d 
## Summary

`@elastic/[email protected]` ⏩ `@elastic/[email protected]`

---

## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0)

- Improved the contrast ratio of meta labels within
`EuiSelectableTemplateSitewide` to meet WCAG AA guidelines.
([#6761](elastic/eui#6761))
- Added `vulnerabilityManagementApp` glyph to `EuiIcon`
([#6762](elastic/eui#6762))
- Added `logoVulnerabilityManagement` icon to `EuiIcon`
([#6763](elastic/eui#6763))
- Added `onPanelChange` callback to `EuiContextMenu` to provide consumer
access to `panelId` and `direction`.
([#6767](elastic/eui#6767))

**Bug fixes**

- Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full
height and vertically centered.
([#6766](elastic/eui#6766))
- Improved the uniformity of dropdown components by hiding the dropdown
icon of disabled `EuiComboBox`s.
([#6768](elastic/eui#6768))

**Breaking changes**

- `EuiFieldNumber` now defaults the `step` prop to `"any"`
([#6760](elastic/eui#6760))
- EUI now globally resets a default Chromium browser style that was
decreasing the opacity of disabled `select` items.
([#6768](elastic/eui#6768))

---------

Co-authored-by: Kibana Machine <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@tkajtoch @kibanamachine @delanni
Upgrade EUI to v80.0.0 (elastic#157939)
030da3b 
## Summary

`@elastic/[email protected]` ⏩ `@elastic/[email protected]`

---

## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0)

- Improved the contrast ratio of meta labels within
`EuiSelectableTemplateSitewide` to meet WCAG AA guidelines.
([elastic#6761](elastic/eui#6761))
- Added `vulnerabilityManagementApp` glyph to `EuiIcon`
([elastic#6762](elastic/eui#6762))
- Added `logoVulnerabilityManagement` icon to `EuiIcon`
([elastic#6763](elastic/eui#6763))
- Added `onPanelChange` callback to `EuiContextMenu` to provide consumer
access to `panelId` and `direction`.
([elastic#6767](elastic/eui#6767))

**Bug fixes**

- Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full
height and vertically centered.
([elastic#6766](elastic/eui#6766))
- Improved the uniformity of dropdown components by hiding the dropdown
icon of disabled `EuiComboBox`s.
([elastic#6768](elastic/eui#6768))

**Breaking changes**

- `EuiFieldNumber` now defaults the `step` prop to `"any"`
([elastic#6760](elastic/eui#6760))
- EUI now globally resets a default Chromium browser style that was
decreasing the opacity of disabled `select` items.
([elastic#6768](elastic/eui#6768))

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@panda01 panda01

Labels
bug Fixes for quality problems that affect the customer experience review v5.0.0-alpha2 v5.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panda01 @rashidkpc @prashanttct07 @epixa