-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 3030 (CHUNKING, BINARYMIME) support #81
Comments
Server part has been merged in #106. Keeping this issue opened for client support. |
I'm test BINARYMIME and get error. What i do. Send mail with attachment (10mb size) like this
I checked source and found this error generated LimitReader when readLine is got limit. But when we used BDAT and BINARYMIME content not split by lines From RFC3030
I can set bigger MaxLineLength but think this not really right solution |
Oh well, this is a problem. Perhaps we could disable lineLimitReader while reading a BDAT chunk? Can you make a PR? |
Looks like a good idea to me too. |
Yes. I investigate problem and send PR |
What would be a good chunk size for BDAT? Should we only use BDAT when PIPELINING is also available (to avoid having to wait for the server ACK'ing each chunk)? |
I'm send really big data. For work purpose i'm need send 8Gb data file. And use really big chunk size. I think usefull size 1Megabyte. |
CHUNKING (BDAT) support
Client support: Prefer over DATA if available (avoids the overhead of dot-encoding), require if BODY=BINARYMIME is used (as required by spec).
Server support: Transparent support, io.Reader passed to Session.Data reads multiple chunks. Error returned by Data early consumes the current chunk and returns an error without consuming the whole message.
BINARYMIME support
Support BODY=BINARYMIME argument for MAIL command, no other actions required.
Specification: https://tools.ietf.org/html/rfc3030
The text was updated successfully, but these errors were encountered: