Server-side CHUNKING and BINARYMIME support #106
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 62.52% 62.21% -0.31%
==========================================
Files 8 8
Lines 982 1101 +119
==========================================
+ Hits 614 685 +71
- Misses 275 309 +34
- Partials 93 107 +14
Continue to review full report at Codecov.
|
backend.go
Outdated
| @@ -24,6 +24,9 @@ type Backend interface { | |||
| // MailOptions contains custom arguments that were | |||
| // passed as an argument to the MAIL command. | |||
| type MailOptions struct { | |||
| // Value of BODY= argument, 7BIT, 8BITMIME or BINARYMIME. | |||
| Body string | |||
There was a problem hiding this comment.
Should we provide a type and constants for valid values?
conn.go
Outdated
|
|
||
| select { | ||
| case <-c.dataResult: | ||
| c.dataResult <- errPanic |
There was a problem hiding this comment.
We can unconditionally send the error to the dataResult channel here I think.
There was a problem hiding this comment.
You are right, I forgot to update this path when copy-pasting code from previous PR.
conn.go
Outdated
| io.Copy(ioutil.Discard, &chunk) | ||
|
|
||
| code, enhancedCode, msg := toSMTPStatus(err) | ||
| c.WriteResponse(code, enhancedCode, msg) |
There was a problem hiding this comment.
Style nit: I think this works:
c.WriteResponse(toSMTPStatus(err))
|
Also please squash the commits into logical commits. |
|
I just realized I have local changes I forgot to commit that resolve some of issues you mentioned. :) |
See #81. This issue is not closed since it also references client support.
Replaces #104 (but hey, that initial solution saves one message copy :) )