-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-side CHUNKING and BINARYMIME support #104
Conversation
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 62.52% 64.64% +2.12%
==========================================
Files 8 9 +1
Lines 982 1140 +158
==========================================
+ Hits 614 737 +123
- Misses 275 302 +27
- Partials 93 101 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this chunkReader
approach, can't we read data directly from handleBdat
and forward it to the backend via an io.Pipe
?
pr, pw := io.Pipe()
go c.Session().Data(pr)
lr := io.LimitedReader{R: c.text.R, N: size}
io.Copy(pw, lr)
I wanted to preserve ability for backend to return errors without consuming the whole message but I will look if this is easily possible with io.Pipe. |
|
See #81. This issue is not closed since it also references client support.