MAINT: Fix deprecated attribute 'convert' to comply with attrs 19.2.0 #271
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses issue #270. |
itziakos
requested changes
Oct 2, 2019
There was a problem hiding this comment.
Thanks for the fix.
Please also update the minimum requirement for attrs to 17.4.0 https://github.com/enthought/sat-solver/blob/master/setup.py#L17
msfschaffner
force-pushed
the
attrs-19.2.0
branch
from
3e7f8e3 to
9a82b0d
Compare
itziakos
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attrs package 19.2.0, which has been released yesterday, deprecates the attribute
convert. It's basically just renamed toconverter, so the fix is lightweight. See alsoLet me know if I should change anything in this PR.