Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pinned attrs dependency from python-requirements.txt #305

Closed
tjaychen opened this issue Oct 1, 2019 · 6 comments · Fixed by #410
Closed

Remove pinned attrs dependency from python-requirements.txt #305

tjaychen opened this issue Oct 1, 2019 · 6 comments · Fixed by #410
Assignees
@tjaychen

Comments

@tjaychen
Copy link

tjaychen commented Oct 1, 2019

Revert #302 once sat solver fixes are upstreamed.
@tjaychen tjaychen self-assigned this Oct 1, 2019
@tjaychen
Copy link
Author

tjaychen commented Oct 1, 2019

@msfschaffner

@asb
Copy link
Member

asb commented Oct 2, 2019

I've submitted #311 which moves the workaround to python-requirements.txt, which will benefit users beyond the CI. Once that is merged, I proposed we edit this issue title+description to reflect that the workaround lives in python-requirements.txt.

The upstream simplesat issue is enthought/sat-solver#270

@asb asb changed the title Revert fix in azure build script Remove pinned attrs dependency from python-requirements.txt Oct 2, 2019
@msfschaffner
Copy link
Contributor

I've submitted a PR to fix this upstream: enthought/sat-solver#271

@tjaychen
Copy link
Author

tjaychen commented Oct 2, 2019

thanks @asb!

@msfschaffner
Copy link
Contributor

a new version of the SAT solver (containing the patch above) has been released: https://github.com/enthought/sat-solver/releases/tag/v0.8.2

but I could not yet test whether it works with fusesoc.

@asb
Copy link
Member

asb commented Oct 8, 2019

I saw that, not listed on pypi yet though https://pypi.org/project/simplesat/#history

@asb asb mentioned this issue Oct 10, 2019
Merged
@asb asb closed this as completed in #410 Oct 10, 2019
asb added a commit that referenced this issue Oct 10, 2019
@asb
Remove pinned attrs version from python-requirements.txt
24df721 
Fixes #305.

simplesat (required by fusesoc) was broken by an update to the attrs
library. Now simplesat 0.8.2 has been released which fixes the issue, we
can remove the explicit pinning of the old attrs version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjaychen tjaychen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pinned attrs version from python-requirements.txt
3 participants
@asb @tjaychen @msfschaffner