Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release of attrs package (19.2.0) breaks simplesat. #270

Closed
benreynwar opened this issue Oct 1, 2019 · 3 comments
Closed

New release of attrs package (19.2.0) breaks simplesat. #270

benreynwar opened this issue Oct 1, 2019 · 3 comments

Comments

@benreynwar
Copy link

The attrs package recently released a new version (19.2.0) which breaks simplesat.

Python 3.7.3 (default, Aug 20 2019, 17:04:43) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import simplesat
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ben/.virtualenvs/deleteme/lib/python3.7/site-packages/simplesat/__init__.py", line 3, in <module>
    from .constraints import Requirement, InstallRequirement
  File "/home/ben/.virtualenvs/deleteme/lib/python3.7/site-packages/simplesat/constraints/__init__.py", line 5, in <module>
    from .constraint_modifiers import (
  File "/home/ben/.virtualenvs/deleteme/lib/python3.7/site-packages/simplesat/constraints/constraint_modifiers.py", line 85, in <module>
    class ConstraintModifiers(object):
  File "/home/ben/.virtualenvs/deleteme/lib/python3.7/site-packages/simplesat/constraints/constraint_modifiers.py", line 86, in ConstraintModifiers
    allow_newer = attr(**_coerced_set)
TypeError: attrib() got an unexpected keyword argument 'convert'
@tjaychen tjaychen mentioned this issue Oct 1, 2019
Merged
This was referenced Oct 2, 2019
Merged
Closed
asb added a commit to lowRISC/opentitan that referenced this issue Oct 2, 2019
@asb
Fix fusesoc dependency breakage using python-requirements.txt
72f8a8d 
In #302, azure-pipelines.yml was modified to ensure that attrs 19.1.0 is
installed. This is because 19.2.0 breaks FuseSoC via the simplesat
dependency (see enthought/sat-solver#270).
While the edits to azure-pipelines.yml fixed CI, users following the
getting started guide are still going to run into this issue. This
commit addresses the problem in an alternative way - by specifying the
version of attrs to use in python-requirements.txt.

Introducing a constraints.txt could have advantages, but that is more
intrusive and would require further doc updates. I feel that would be
overkill for a quick fix workaround that we hope to remove quite
rapidly.
imphil added a commit to imphil/ibex that referenced this issue Oct 2, 2019
@imphil
CI: Unbreak build after simplesat breakage
ec7b910 
Tracked in enthought/sat-solver#270
imphil added a commit to imphil/ibex that referenced this issue Oct 2, 2019
@imphil
CI: Unbreak build after simplesat breakage
bdd6212 
Tracked in enthought/sat-solver#270
@imphil imphil mentioned this issue Oct 2, 2019
Merged
tomeroberts pushed a commit to lowRISC/ibex that referenced this issue Oct 2, 2019
@imphil @tomeroberts
CI: Unbreak build after simplesat breakage
85e1d43 
Tracked in enthought/sat-solver#270
@msfschaffner msfschaffner mentioned this issue Oct 2, 2019
Merged
@itziakos
Copy link
Member

itziakos commented Oct 3, 2019

fixed by #271

@itziakos itziakos closed this as completed Oct 3, 2019
@xmentos
Copy link

xmentos commented Oct 8, 2019

Great and thanks for fixing. Can this be released because it breaks several other packages depending on simplesat (in my case https://github.com/olofk/fusesoc)?

@itziakos
Copy link
Member

@xmentos the updated simplesat version 0.8.2 has been uploaded to pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benreynwar @itziakos @xmentos