Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix compile database generation #6186

Closed
wants to merge 3 commits into from

Conversation

lizan
Copy link
Member

@lizan lizan commented Mar 6, 2019

Signed-off-by: Lizan Zhou [email protected]

Description:
Fixes #6172, but refactors dependency management quite a bit.

Risk Level: Med (may break repos relying on this)
Testing: CI
Docs Changes:
Release Notes:

lizan added 3 commits March 6, 2019 10:00
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs CI fix.

@@ -0,0 +1,2 @@
api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat; I wonder if there are other places we need this (e.g. docs).

@htuch htuch added the waiting label Mar 11, 2019
@lizan lizan mentioned this pull request Mar 12, 2019
@lizan
Copy link
Member Author

lizan commented Mar 12, 2019

Closing in favor of #6229

@lizan lizan closed this Mar 12, 2019
@lizan lizan deleted the compilation_database_fix branch March 12, 2019 00:16
@lizan lizan mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants