-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: fix bazel query again #6463
Conversation
Signed-off-by: Dan Rosen <[email protected]>
/review @lizan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can run this command in CI to catch issues?
Yeah, would be ideal to just make this part of the |
What do you think if we make /api a fully considered as a external repository? |
+1, I also made a partial effort at #6186 |
Yes #6229 as well, as a consequence they need to be in one PR, but I haven't resolve the CI Issue with that. |
Of course landing this PR is the priority. If you guys don't mind, I can work on /api isolation to prevent future breakage. |
Sure feel free to take it. @silentdai |
Description: fix "bazel query ..." again.
Risk Level: low
Testing: "bazel query ..." works.
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Dan Rosen [email protected]