Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix bazel query again #6463

Merged
merged 1 commit into from
Apr 3, 2019
Merged

api: fix bazel query again #6463

merged 1 commit into from
Apr 3, 2019

Conversation

mergeconflict
Copy link
Member

Description: fix "bazel query ..." again.
Risk Level: low
Testing: "bazel query ..." works.
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Dan Rosen [email protected]

@mergeconflict
Copy link
Member Author

/review @lizan

@repokitteh-read-only repokitteh-read-only bot requested a review from lizan April 2, 2019 17:41
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can run this command in CI to catch issues?

@htuch
Copy link
Member

htuch commented Apr 2, 2019

Yeah, would be ideal to just make this part of the api CI job.

@lambdai
Copy link
Contributor

lambdai commented Apr 3, 2019

What do you think if we make /api a fully considered as a external repository?
Below has the partial effort.
https://github.com/envoyproxy/envoy/blob/master/bazel/repositories.bzl#L133

@lizan
Copy link
Member

lizan commented Apr 3, 2019

What do you think if we make /api a fully considered as a external repository?
Below has the partial effort.
https://github.com/envoyproxy/envoy/blob/master/bazel/repositories.bzl#L133

+1, I also made a partial effort at #6186

@lambdai
Copy link
Contributor

lambdai commented Apr 3, 2019

@lizan not #6229 ?

@lizan
Copy link
Member

lizan commented Apr 3, 2019

Yes #6229 as well, as a consequence they need to be in one PR, but I haven't resolve the CI Issue with that.

@lambdai
Copy link
Contributor

lambdai commented Apr 3, 2019

Of course landing this PR is the priority.

If you guys don't mind, I can work on /api isolation to prevent future breakage.

@lizan
Copy link
Member

lizan commented Apr 3, 2019

Sure feel free to take it. @silentdai

@lizan lizan merged commit d8e0f9c into envoyproxy:master Apr 3, 2019
@mergeconflict mergeconflict deleted the fix_bazel_query_again branch April 10, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants