Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source link integration broken #644

Closed
rasmus opened this issue May 26, 2019 · 4 comments · Fixed by #645
Closed

Source link integration broken #644

rasmus opened this issue May 26, 2019 · 4 comments · Fixed by #645
Labels
bug

Comments

@rasmus
Copy link
Member

rasmus commented May 26, 2019 •
edited
Loading

While the NuGet package look OK, there's something wrong. The source isn't automatically downloaded when stepped through.

image

There might be some details here: ctaggart/SourceLink#306
@rasmus rasmus mentioned this issue May 26, 2019
Closed
@rasmus
Copy link
Member Author

rasmus commented May 26, 2019

It should be as simple as described here https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx

@rasmus rasmus added the bug label May 26, 2019
@rasmus rasmus mentioned this issue May 26, 2019
Merged
@rasmus
Copy link
Member Author

rasmus commented May 26, 2019

SNUPKG packages are empty

image

@rasmus rasmus mentioned this issue May 26, 2019
Merged
@rasmus
Copy link
Member Author

rasmus commented May 28, 2019

Released in v0.72.3914 along with PDB files (instead of embedding them in the assemblies). Remember to disable "just my code"

@rasmus
Copy link
Member Author

rasmus commented May 28, 2019

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Fix source link integration eventflow/EventFlow
1 participant
@rasmus