Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix source link integration #645

Merged
merged 18 commits into from
May 27, 2019
Merged

WIP: Fix source link integration #645

merged 18 commits into from
May 27, 2019

Conversation

rasmus
Copy link
Member

@rasmus rasmus commented May 26, 2019

Fixes #644

@rasmus
Copy link
Member Author

rasmus commented May 26, 2019

PDB file no longer embedded, but present in snupkg file.

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #645 into develop will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #645      +/-   ##
===========================================
- Coverage    72.32%   72.16%   -0.17%     
===========================================
  Files          317      317              
  Lines         7910     7910              
  Branches      2319     2319              
===========================================
- Hits          5721     5708      -13     
  Misses        1433     1433              
- Partials       756      769      +13
Impacted Files Coverage Δ
...l/SnapshotStores/PostgresSqlSnapshotPersistence.cs 67.21% <0%> (-13.12%) ⬇️
...EventFlow/Configuration/Bootstraps/Bootstrapper.cs 92.59% <0%> (-3.71%) ⬇️
...w.MsSql/RetryStrategies/MsSqlErrorRetryStrategy.cs 48.27% <0%> (-3.45%) ⬇️
...Core/VersionedTypes/VersionedTypeUpgradeService.cs 78.37% <0%> (-2.71%) ⬇️
...EventFlow/ReadStores/InMemory/InMemoryReadStore.cs 69.56% <0%> (-2.18%) ⬇️
...ce/EventFlow/Sagas/AggregateSagas/AggregateSaga.cs 91.3% <0%> (-2.18%) ⬇️
Source/EventFlow/Sagas/DispatchToSagas.cs 87.67% <0%> (-1.37%) ⬇️
...entFlow/EventStores/Files/FilesEventPersistence.cs 69.11% <0%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9ceb7...67ff927. Read the comment docs.

@rasmus rasmus merged commit 532eca2 into develop May 27, 2019
@rasmus rasmus deleted the fix-source-link branch May 27, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source link integration broken
1 participant