Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing symbols #639

Merged
merged 6 commits into from
May 26, 2019
Merged

Publishing symbols #639

merged 6 commits into from
May 26, 2019

Conversation

rasmus
Copy link
Member

@rasmus rasmus commented May 15, 2019

AppVeyor doesn't pick up .snupkg files according to appveyor/ci#2753.

Documentation here: https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg

EventFlow correctly builds the packages after #638

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #639 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #639   +/-   ##
========================================
  Coverage    72.26%   72.26%           
========================================
  Files          317      317           
  Lines         7910     7910           
  Branches      2222     2319   +97     
========================================
  Hits          5716     5716           
- Misses        1428     1429    +1     
+ Partials       766      765    -1
Impacted Files Coverage Δ
...Flow.MongoDB/EventStore/MongoDbEventPersistence.cs 66.66% <0%> (-5.56%) ⬇️
...EventFlow/Configuration/Bootstraps/Bootstrapper.cs 92.59% <0%> (-3.71%) ⬇️
...w.MsSql/RetryStrategies/MsSqlErrorRetryStrategy.cs 48.27% <0%> (-3.45%) ⬇️
...Core/VersionedTypes/VersionedTypeUpgradeService.cs 78.37% <0%> (-2.71%) ⬇️
...EventFlow/ReadStores/InMemory/InMemoryReadStore.cs 69.56% <0%> (-2.18%) ⬇️
...ce/EventFlow/Sagas/AggregateSagas/AggregateSaga.cs 91.3% <0%> (-2.18%) ⬇️
...entFlow/EventStores/Files/FilesEventPersistence.cs 70.58% <0%> (-1.48%) ⬇️
Source/EventFlow/Sagas/DispatchToSagas.cs 87.67% <0%> (-1.37%) ⬇️
...tgreSql/EventStores/PostgresSqlEventPersistence.cs 62.36% <0%> (+6.45%) ⬆️
...ngoDB/SnapshotStores/MongoDbSnapshotPersistence.cs 96.07% <0%> (+9.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d47278...1e2c5c7. Read the comment docs.

@rasmus
Copy link
Member Author

rasmus commented May 15, 2019

@rasmus
Copy link
Member Author

rasmus commented May 16, 2019

snupkg seems empty

@rasmus rasmus changed the title Symbols Publishing symbols May 26, 2019
@rasmus
Copy link
Member Author

rasmus commented May 26, 2019

Although the source link integration is broken, we should still publish the snupkg packages #644

@rasmus rasmus merged commit a754e12 into develop May 26, 2019
@rasmus rasmus deleted the symbols branch May 26, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant