Fix 'Write past Buffer capacity()' Bug #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tanjialiang
force-pushed
the
vector_bug_fix
branch
from
0d99504 to
3d33423
Compare
|
@tanjialiang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mbasmanova
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
@tanjialiang Looks good to me. Thank you for adding a test.
|
@tanjialiang merged this pull request in ccfdd0e. |
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 8, 2023
Support tiny int, small int and date for IN filter pushdown.
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 9, 2023
Support tiny int, small int and date for IN filter pushdown.
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Apr 1, 2023
Support tiny int, small int and date for IN filter pushdown.
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Apr 23, 2023
Support tiny int, small int and date for IN filter pushdown.
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a constant vector size is smaller than the selectivity vector size, the ensuring of writing buffer used to use the constant vector's size as the target vector size. This caused subsequent write to the raw buffer of the vector exceeding its allocated memory, causing the 'write past buffer capacity()' error.
Added unit tests to guard this situation.