Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve test coverage #169

Closed

Conversation

mbasmanova
Copy link
Contributor

An illustration to compliment code review for #162

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2021
@mbasmanova
Copy link
Contributor Author

Not needed anymore.

@mbasmanova mbasmanova closed this Sep 8, 2021
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Mar 17, 2023
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Mar 31, 2023
facebookincubator#169)

* Fix null on overflow and multiply as spark precision.
* Fix cast double to decimal.
* Support casting from varchar to decimal.
liujiayi771 pushed a commit to liujiayi771/velox that referenced this pull request Apr 1, 2023
facebookincubator#169)

* Fix null on overflow and multiply as spark precision.
* Fix cast double to decimal.
* Support casting from varchar to decimal.
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Apr 23, 2023
facebookincubator#169)

* Fix null on overflow and multiply as spark precision.
* Fix cast double to decimal.
* Support casting from varchar to decimal.
zhouyuan pushed a commit to zhouyuan/velox that referenced this pull request Jun 7, 2023
relative pr:

Support more data types for read filter facebookincubator#139
Fix cast double to decimal facebookincubator#179
Fix casting from string to decimal facebookincubator#281
Support cast decimal to int facebookincubator#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169
Disable tokenizing the path by dot facebookincubator#109
Serialize and deserialize RowVector facebookincubator#250
Support datetime pattern in spark facebookincubator#94
Yohahaha pushed a commit to Yohahaha/velox that referenced this pull request Jul 4, 2023
relative pr:

Support more data types for read filter facebookincubator#139
Fix cast double to decimal facebookincubator#179
Fix casting from string to decimal facebookincubator#281
Support cast decimal to int facebookincubator#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169
Disable tokenizing the path by dot facebookincubator#109
Serialize and deserialize RowVector facebookincubator#250
Support datetime pattern in spark facebookincubator#94
chenxu14 pushed a commit to chenxu14/velox that referenced this pull request Jul 5, 2023
relative pr:

Support more data types for read filter facebookincubator#139
Fix cast double to decimal facebookincubator#179
Fix casting from string to decimal facebookincubator#281
Support cast decimal to int facebookincubator#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169
Disable tokenizing the path by dot facebookincubator#109
Serialize and deserialize RowVector facebookincubator#250
Support datetime pattern in spark facebookincubator#94
PHILO-HE pushed a commit to PHILO-HE/velox that referenced this pull request Jul 17, 2023
relative pr:

Support more data types for read filter facebookincubator#139
Fix cast double to decimal facebookincubator#179
Fix casting from string to decimal facebookincubator#281
Support cast decimal to int facebookincubator#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169
Disable tokenizing the path by dot facebookincubator#109
Serialize and deserialize RowVector facebookincubator#250
Support datetime pattern in spark facebookincubator#94
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Jul 21, 2023
relative pr:

Support more data types for read filter facebookincubator#139
Fix cast double to decimal facebookincubator#179
Fix casting from string to decimal facebookincubator#281
Support cast decimal to int facebookincubator#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169
Disable tokenizing the path by dot facebookincubator#109
Serialize and deserialize RowVector facebookincubator#250
Support datetime pattern in spark facebookincubator#94
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Jul 24, 2023
relative pr:

Support more data types for read filter facebookincubator#139
Fix cast double to decimal facebookincubator#179
Fix casting from string to decimal facebookincubator#281
Support cast decimal to int facebookincubator#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169
Disable tokenizing the path by dot facebookincubator#109
Serialize and deserialize RowVector facebookincubator#250
Support datetime pattern in spark facebookincubator#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants