-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve test coverage #169
Closed
mbasmanova
wants to merge
2
commits into
facebookincubator:main
from
mbasmanova:improve-test-coverage
Closed
[WIP] Improve test coverage #169
mbasmanova
wants to merge
2
commits into
facebookincubator:main
from
mbasmanova:improve-test-coverage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not needed anymore. |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 31, 2023
facebookincubator#169) * Fix null on overflow and multiply as spark precision. * Fix cast double to decimal. * Support casting from varchar to decimal.
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Apr 1, 2023
facebookincubator#169) * Fix null on overflow and multiply as spark precision. * Fix cast double to decimal. * Support casting from varchar to decimal.
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Apr 23, 2023
facebookincubator#169) * Fix null on overflow and multiply as spark precision. * Fix cast double to decimal. * Support casting from varchar to decimal.
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An illustration to compliment code review for #162