Use std::copy instead of memcpy #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I'm debugging a crash in DecodedVector where indices_ is unexpectedly null. In mode/dev, the program is killed before I get to the relevant crash if the src parameter is null even if the size is zero. std::copy doesn't do this. Performance of std::copy should be identical to memcpy. Reviewed By: pedroerp Differential Revision: D30978509 fbshipit-source-id: 5e81d457bb69ac2b93882d37b31378ece187196f
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30978509 |
|
This pull request has been merged in 492e0ec. |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
…ncubator#250) * fix backend velox codestyle * change remark codestyle to compact mode and add intellij codestyle xml
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Serialize and deserialize RowVector facebookincubator#250
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Serialize and deserialize RowVector facebookincubator#250
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Serialize and deserialize RowVector facebookincubator#250
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Serialize and deserialize RowVector facebookincubator#250
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Serialize and deserialize RowVector facebookincubator#250
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Serialize and deserialize RowVector facebookincubator#250
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Support more data types for read filter facebookincubator#139 Fix cast double to decimal facebookincubator#179 Fix casting from string to decimal facebookincubator#281 Support cast decimal to int facebookincubator#177 Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169 Disable tokenizing the path by dot facebookincubator#109 Serialize and deserialize RowVector facebookincubator#250 Support datetime pattern in spark facebookincubator#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm debugging a crash in DecodedVector where indices_ is unexpectedly null. In
mode/dev, the program is killed before I get to the relevant crash if the src
parameter is null even if the size is zero. std::copy doesn't do this.
Performance of std::copy should be identical to memcpy.
Reviewed By: pedroerp
Differential Revision: D30978509